Skip to content

Commit 9f219cb

Browse files
fix: add error logging to cloudflared socket handler empty catch blocks (#6617)
2 parents 11a2b8e + 951f109 commit 9f219cb

1 file changed

Lines changed: 12 additions & 4 deletions

File tree

server/socket-handlers/cloudflared-socket-handler.js

Lines changed: 12 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -41,14 +41,18 @@ module.exports.cloudflaredSocketHandler = (socket) => {
4141
io.to(socket.userID).emit(prefix + "installed", cloudflared.checkInstalled());
4242
io.to(socket.userID).emit(prefix + "running", cloudflared.running);
4343
io.to(socket.userID).emit(prefix + "token", await setting("cloudflaredTunnelToken"));
44-
} catch (error) { }
44+
} catch (error) {
45+
log.error("cloudflared", "Error in join handler: " + error.message);
46+
}
4547
});
4648

4749
socket.on(prefix + "leave", async () => {
4850
try {
4951
checkLogin(socket);
5052
socket.leave("cloudflared");
51-
} catch (error) { }
53+
} catch (error) {
54+
log.error("cloudflared", "Error in leave handler: " + error.message);
55+
}
5256
});
5357

5458
socket.on(prefix + "start", async (token) => {
@@ -61,7 +65,9 @@ module.exports.cloudflaredSocketHandler = (socket) => {
6165
cloudflared.token = null;
6266
}
6367
cloudflared.start();
64-
} catch (error) { }
68+
} catch (error) {
69+
log.error("cloudflared", "Error in start handler: " + error.message);
70+
}
6571
});
6672

6773
socket.on(prefix + "stop", async (currentPassword, callback) => {
@@ -84,7 +90,9 @@ module.exports.cloudflaredSocketHandler = (socket) => {
8490
try {
8591
checkLogin(socket);
8692
await setSetting("cloudflaredTunnelToken", "");
87-
} catch (error) { }
93+
} catch (error) {
94+
log.error("cloudflared", "Error in removeToken handler: " + error.message);
95+
}
8896
});
8997

9098
};

0 commit comments

Comments
 (0)