fix: add error logging to cloudflared socket handler empty catch blocks#6617
Merged
CommanderStorm merged 1 commit intolouislam:masterfrom Jan 6, 2026
Conversation
Previously, errors in cloudflared socket handlers were silently swallowed by empty catch blocks, making debugging difficult. This commit adds proper error logging to all empty catch blocks in the cloudflared socket handler to improve observability and debugging. - Added error logging to join handler - Added error logging to leave handler - Added error logging to start handler - Added error logging to removeToken handler
CommanderStorm
approved these changes
Jan 6, 2026
Collaborator
CommanderStorm
left a comment
There was a problem hiding this comment.
makes sense to me
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, errors in cloudflared socket handlers were silently swallowed by empty catch blocks, making debugging difficult. This commit adds proper error logging to all empty catch blocks in the cloudflared socket handler to improve observability and debugging.
ℹ️ To keep reviews fast and effective, please make sure you’ve read our pull request guidelines
📝 Summary of changes done and why they are done
📋 Related issues
📄 Checklist
Please follow this checklist to avoid unnecessary back and forth (click to expand)
I understand that I am responsible for and able to explain every line of code I submit.
📷 Screenshots or Visual Changes
UPDOWN