Skip to content

remove: drop LINE Notify integration#6088

Merged
CommanderStorm merged 7 commits intolouislam:masterfrom
xNewz:master
Dec 30, 2025
Merged

remove: drop LINE Notify integration#6088
CommanderStorm merged 7 commits intolouislam:masterfrom
xNewz:master

Conversation

@xNewz
Copy link
Copy Markdown
Contributor

@xNewz xNewz commented Aug 29, 2025

❗ Important Announcements

Click here for more details:

⚠️ Please Note: We do not accept all types of pull requests, and we want to ensure we don’t waste your time. Before submitting, make sure you have read our pull request guidelines: Pull Request Rules

🚫 Please Avoid Unnecessary Pinging of Maintainers

We kindly ask you to refrain from pinging maintainers unless absolutely necessary. Pings are for critical/urgent pull requests that require immediate attention.

📋 Overview

  • Removed LINE Notify provider code (backend + frontend)

👉 LINE integration is still available through the LINE provider (based on the LINE Messaging API). Please migrate to LINE Messenger if you need to continue receiving alerts via LINE.

The UI component you should continue using is src/components/notifications/Line.vue.

  • What problem does this pull request address?
    • LINE Notify (https://notify-bot.line.me/) has officially ended its service.
      The integration inside Uptime Kuma is no longer functional. Keeping this option
      confuses users, creates dead code, and increases maintenance burden.
  • What features or functionality does this pull request introduce or enhance?
    • Removes LINE Notify notification provider completely
      • Deleted provider implementation under server/notification-providers/
      • Removed registration in server/notification.js
      • Cleaned up frontend files (NotificationDialog.vue, related UI)
  • Relates to #issue-number
  • Resolves #issue-number

🛠️ Type of change

  • 🐛 Bugfix (a non-breaking change that resolves an issue)
  • ✨ New feature (a non-breaking change that adds new functionality)
  • ⚠️ Breaking change (a fix or feature that alters existing functionality in a way that could cause issues)
  • 🎨 User Interface (UI) updates
  • 📄 New Documentation (addition of new documentation)
  • 📄 Documentation Update (modification of existing documentation)
  • 📄 Documentation Update Required (the change requires updates to related documentation)
  • 🔧 Other (please specify):
    • Provide additional details here.

📄 Checklist

  • 🔍 My code adheres to the style guidelines of this project.
  • 🦿 I have indicated where (if any) I used an LLM for the contributions
  • ✅ I ran ESLint and other code linters for modified files.
  • 🛠️ I have reviewed and tested my code.
  • 📝 I have commented my code, especially in hard-to-understand areas (e.g., using JSDoc for methods).
  • ⚠️ My changes generate no new warnings.
  • 🤖 My code needed automated testing. I have added them (this is an optional task).
  • 📄 Documentation updates are included (if applicable).
  • 🔒 I have considered potential security impacts and mitigated risks.
  • 🧰 Dependency updates are listed and explained.
  • 📚 I have read and understood the Pull Request guidelines.

📷 Screenshots or Visual Changes

  • UI Modifications: Highlight any changes made to the user interface.
  • Before & After: Include screenshots or comparisons (if applicable).
Event Before After
UP Before After
DOWN Before After
Certificate-expiry Before After
Testing Before After

Copy link
Copy Markdown
Collaborator

@CommanderStorm CommanderStorm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of removing, I would like to see Line being migrated as discussed in

Basically, the changes from said PR plus dediding how to name it.

@CommanderStorm CommanderStorm added the pr:please address review comments this PR needs a bit more work to be mergable label Aug 29, 2025
@xNewz
Copy link
Copy Markdown
Contributor Author

xNewz commented Aug 29, 2025

LINE Messaging API already being implemented in Line.vue

@CommanderStorm
Copy link
Copy Markdown
Collaborator

CommanderStorm commented Aug 29, 2025

Good point.

Are api keys for this different? Could we mirate users over?
In general, what happens if I have line notify confiugred and have not looked at it since may.
Will merging this crash-loop those users or what will happen to them 🤔

@xNewz
Copy link
Copy Markdown
Contributor Author

xNewz commented Aug 29, 2025

LINE Notify has already been officially discontinued as of March 31, 2025 the service and APIs can no longer be used at all. Because of that, existing LINE Notify configurations are already non-functional regardless of whether this PR is merged.

LINE itself recommends migrating to the LINE Messaging API, which is already implemented in Line.vue. The API keys and setup are different, so users can’t be automatically migrated over. They will need to reconfigure using the Messaging API in order to restore notification functionality.

Merging this PR won’t crash-loop users. it just removes the dead Notify integration that no longer works.

@CommanderStorm
Copy link
Copy Markdown
Collaborator

CommanderStorm commented Sep 16, 2025

I think we still need to do a migration, even if this were to not crash loop users.
I would like to have the db not be in a weird state where it has montiors registered that don't exist.

@CommanderStorm
Copy link
Copy Markdown
Collaborator

@xNewz would you be open to doing this db migration too?

@CommanderStorm CommanderStorm added the question Further information is requested label Dec 23, 2025
@xNewz xNewz closed this Dec 29, 2025
@xNewz
Copy link
Copy Markdown
Contributor Author

xNewz commented Dec 29, 2025

I’ve added a DB migration to clean up legacy LINE Notify configs.
It detects LineNotify / line-notify notification records, removes their monitor_notification links, and deletes the notifications in a single transaction to avoid leaving the DB in an inconsistent state.

The down migration is a no-op since the deleted configs cannot be meaningfully restored.

@CommanderStorm
Copy link
Copy Markdown
Collaborator

Thanks 🙏
I think there was a small issue with git in the last push.

Could you please re-remove the original changes?
The frontend/notification provider is still there, you replaced it with the migration.
I would prefer to also merge this with your original changes of removing this fully as with just the migration you can still create the notification provider.

@xNewz
Copy link
Copy Markdown
Contributor Author

xNewz commented Dec 30, 2025

Sorry about that 🙏 I’ve re-applied the full LINE Notify removal, kept the migration, and also fixed the websocket issues (handling missing error messages and using a random port for the insecure websocket test). Thanks!

@CommanderStorm
Copy link
Copy Markdown
Collaborator

Sorry to string you along.

I think there was a merge issue with the websocket code.
Those changes seem accidental
Could you remove those?

We can merge afterwards, sorry

@xNewz
Copy link
Copy Markdown
Contributor Author

xNewz commented Dec 30, 2025

I’ve removed the unintended websocket changes. We can merge when you’re ready.

Copy link
Copy Markdown
Collaborator

@CommanderStorm CommanderStorm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work and thank you for being persistent enough to push this through

@CommanderStorm CommanderStorm merged commit 271a2d3 into louislam:master Dec 30, 2025
20 checks passed
@CommanderStorm CommanderStorm removed the pr:please address review comments this PR needs a bit more work to be mergable label Jan 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

question Further information is requested

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants