Skip to content

feat: Add Messaging Service SID option for Twilio#6347

Merged
CommanderStorm merged 12 commits intolouislam:masterfrom
SomeoneVeryCool:feature/update-notification-provider-twilio-messagingservicesid
Nov 17, 2025
Merged

feat: Add Messaging Service SID option for Twilio#6347
CommanderStorm merged 12 commits intolouislam:masterfrom
SomeoneVeryCool:feature/update-notification-provider-twilio-messagingservicesid

Conversation

@SomeoneVeryCool
Copy link
Copy Markdown
Contributor

❗ Important Announcements

Click here for more details:

⚠️ Please Note: We do not accept all types of pull requests, and we want to ensure we don’t waste your time. Before submitting, make sure you have read our pull request guidelines: Pull Request Rules

🚫 Please Avoid Unnecessary Pinging of Maintainers

We kindly ask you to refrain from pinging maintainers unless absolutely necessary. Pings are for critical/urgent pull requests that require immediate attention.

📋 Overview

  • What problem does this pull request address?
    • Pushing SMS requests through volume messaging service.
  • What features or functionality does this pull request introduce or enhance?
    • Allows users to optionally add Messaging Service SID for the Twilio config

🛠️ Type of change

  • 🐛 Bugfix (a non-breaking change that resolves an issue)
  • ✨ New feature (a non-breaking change that adds new functionality)
  • ⚠️ Breaking change (a fix or feature that alters existing functionality in a way that could cause issues)
  • 🎨 User Interface (UI) updates
  • 📄 New Documentation (addition of new documentation)
  • 📄 Documentation Update (modification of existing documentation)
  • 📄 Documentation Update Required (the change requires updates to related documentation)
  • 🔧 Other (please specify):
    • Provide additional details here.

📄 Checklist

  • 🔍 My code adheres to the style guidelines of this project.
  • 🦿 I have indicated where (if any) I used an LLM for the contributions
  • ✅ I ran ESLint and other code linters for modified files.
  • 🛠️ I have reviewed and tested my code.
  • 📝 I have commented my code, especially in hard-to-understand areas (e.g., using JSDoc for methods).
  • ⚠️ My changes generate no new warnings.
  • 🤖 My code needed automated testing. I have added them (this is an optional task).
  • 📄 Documentation updates are included (if applicable).
  • 🔒 I have considered potential security impacts and mitigated risks.
  • 🧰 Dependency updates are listed and explained.
  • 📚 I have read and understood the Pull Request guidelines.

📷 Screenshots or Visual Changes

Before Changes
image

After Changes
image

Copy link
Copy Markdown
Collaborator

@CommanderStorm CommanderStorm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Resonable change.
Lets not continue bad pracitices and have proper translations for this.

Copy link
Copy Markdown
Collaborator

@CommanderStorm CommanderStorm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work and thanks for going through all the helptexts 🎉

I still think we should add a link to the docs, explaining what a SID is is simpler this way 😅

@CommanderStorm CommanderStorm added this to the 2.1.0 milestone Nov 15, 2025
@CommanderStorm CommanderStorm merged commit 2e3b317 into louislam:master Nov 17, 2025
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Unable to add MSID to Twillio

2 participants