Skip to content

Improvements for SMSC i18n#6375

Merged
CommanderStorm merged 3 commits intolouislam:masterfrom
amirparsadd:smsc-i18n-improvements
Nov 19, 2025
Merged

Improvements for SMSC i18n#6375
CommanderStorm merged 3 commits intolouislam:masterfrom
amirparsadd:smsc-i18n-improvements

Conversation

@amirparsadd
Copy link
Copy Markdown
Contributor

📋 Overview

While i was working on the SMSIR notification provider, i noticed that the SMSC notification provider had a few issues regarding the implementation of the You can get API Username and API Key from here. text and i have decided to fix them. these changes include:

  • Removing extra space before the dot from the end of the text
  • Using <template> for placing the "here" link as it is a better way to do so.

🛠️ Type of change

  • 🐛 Bugfix (a non-breaking change that resolves an issue)
  • ✨ New feature (a non-breaking change that adds new functionality)
  • ⚠️ Breaking change (a fix or feature that alters existing functionality in a way that could cause issues)
  • 🎨 User Interface (UI) updates
  • 📄 New Documentation (addition of new documentation)
  • 📄 Documentation Update (modification of existing documentation)
  • 📄 Documentation Update Required (the change requires updates to related documentation)
  • 🔧 Other (please specify):
    • Provide additional details here.

📄 Checklist

  • 🔍 My code adheres to the style guidelines of this project.
  • 🦿 I have indicated where (if any) I used an LLM for the contributions
  • ✅ I ran ESLint and other code linters for modified files.
  • 🛠️ I have reviewed and tested my code.
  • 📝 I have commented my code, especially in hard-to-understand areas (e.g., using JSDoc for methods).
  • ⚠️ My changes generate no new warnings.
  • 🤖 My code needed automated testing. I have added them (this is an optional task).
  • 📄 Documentation updates are included (if applicable).
  • 🔒 I have considered potential security impacts and mitigated risks.
  • 🧰 Dependency updates are listed and explained.
  • 📚 I have read and understood the Pull Request guidelines.

📷 Screenshots or Visual Changes

Changed You can get API Username and API Key from here . to You can get API Username and API Key from here.

@CommanderStorm CommanderStorm added this to the 2.1.0 milestone Nov 19, 2025
@CommanderStorm CommanderStorm enabled auto-merge (squash) November 19, 2025 18:36
@CommanderStorm CommanderStorm merged commit a59a6af into louislam:master Nov 19, 2025
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants