feat: make mariadb max pool connections controllable via env

[amirparsadd]

📋 Overview

I saw an issue saying that mariadb max connections should be controllable through env variables so this PR fixes that with a new env variable:

• MARIADB_POOL_MAX_CONNECTIONS

---

• Resolves Configurable maximum parallel MariaDB connections #6374

🛠️ Type of change

• 🐛 Bugfix (a non-breaking change that resolves an issue)
• ✨ New feature (a non-breaking change that adds new functionality)
• ⚠️ Breaking change (a fix or feature that alters existing functionality in a way that could cause issues)
• 🎨 User Interface (UI) updates
• 📄 New Documentation (addition of new documentation)
• 📄 Documentation Update (modification of existing documentation)
• 📄 Documentation Update Required (the change requires updates to related documentation)
• 🔧 Other (please specify):
  • Provide additional details here.

📄 Checklist

• 🔍 My code adheres to the style guidelines of this project.
• 🦿 I have indicated where (if any) I used an LLM for the contributions
• ✅ I ran ESLint and other code linters for modified files.
• 🛠️ I have reviewed and tested my code.
• 📝 I have commented my code, especially in hard-to-understand areas (e.g., using JSDoc for methods).
• ⚠️ My changes generate no new warnings.
• 🤖 My code needed automated testing. I have added them (this is an optional task).
• 📄 Documentation updates are included (if applicable).
• 🔒 I have considered potential security impacts and mitigated risks.
• 🧰 Dependency updates are listed and explained.
• 📚 I have read and understood the Pull Request guidelines.

📷 Screenshots or Visual Changes

[CommanderStorm]

Could you please make sure that all environment variables stick to our existing naming scheme

https://github.com/louislam/uptime-kuma/wiki/Environment-Variables#mariadb-environment-variables

I am also not entirely sure if the min pool size should be configurable. What is the effect there?

[amirparsadd]

Could you please make sure that all environment variables stick to our existing naming scheme

https://github.com/louislam/uptime-kuma/wiki/Environment-Variables#mariadb-environment-variables

I am also not entirely sure if the min pool size should be configurable. What is the effect there?

It's now following standards and i removed the min connections env

[louislam]

I think it needs some validations. Like checking a empty string, NaN etc. Or maybe number range.

[CommanderStorm]

LGTM now, thanks 🙏
Should be uncontroversial and help the few people on a limited pool Mariadb hoster

[amirparsadd]

@CommanderStorm i added validation as Louis said

[CommanderStorm]

Please polish your code one round.

Please instead default to 10 and then add an if statement if the env var contains a valid number.
Number.MAX_SAFE_INTEGER for example is not a sensible max.

Also please log if a value does not get applied.

[louislam]

Plus, you don't need to call parseInt 4 times.

[amirparsadd]

Changes:

• added reasonable max
• added logging on fail
• removed repetitive parseInt

[amirparsadd]

@CommanderStorm This is ready

[CommanderStorm]

The code isn’t yet at a level where I can merge it.
I’ve given more detailed feedback this time - please incorporate those changes, and then we can move forward.

[CommanderStorm]

I still think that the code quality does not 100% meet what I would like the code to be in terms of readability.

What do you think of my variant of writing ths

[CommanderStorm]

LGTM now with my change