Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR enforces the no-throw-literal ESLint rule to ensure consistent error handling throughout the codebase. The rule prevents throwing non-Error objects, which is a JavaScript best practice.
- Adds
no-throw-literalrule to ESLint configuration as an error - Fixes existing violation in webhook notification provider by wrapping thrown string in Error object
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| .eslintrc.js | Adds no-throw-literal rule to enforce throwing Error objects instead of literals |
| server/notification-providers/webhook.js | Fixes existing violation by changing throw "..." to throw new Error("...") |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Failure message could be undefined because of lacking of this. Also it is a good practice I think.