fix: dynamically adjust beat border radius#6432
Merged
CommanderStorm merged 1 commit intolouislam:masterfrom Nov 28, 2025
Merged
fix: dynamically adjust beat border radius#6432CommanderStorm merged 1 commit intolouislam:masterfrom
CommanderStorm merged 1 commit intolouislam:masterfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes the beat border radius calculation in the HeartbeatBar component to ensure beats maintain their proper pill shape after canvas rendering optimizations introduced in PR #6407.
- Removes the static
beatBorderRadiusproperty from the component's data - Implements dynamic border radius calculation based on beat width (
width / 2) - Ensures pill shapes scale correctly during hover states
CommanderStorm
approved these changes
Nov 28, 2025
Collaborator
CommanderStorm
left a comment
There was a problem hiding this comment.
Nice, thank you!
I totally forgot to check this case during my testing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📋 Overview
What problem does this pull request address?
After optimizing the beat changes in a canvas, their shape was not correct.
What features or functionality does this pull request introduce or enhance?
The border radius of the beats is now calculated dynamically.
divs with Canvas based rendering #6407🛠️ Type of change
📄 Checklist
📷 Screenshots or Visual Changes
Before:
After:
UPDOWN