Skip to content

fix: dynamically adjust beat border radius#6432

Merged
CommanderStorm merged 1 commit intolouislam:masterfrom
kurama:fix/beat-pill-shape
Nov 28, 2025
Merged

fix: dynamically adjust beat border radius#6432
CommanderStorm merged 1 commit intolouislam:masterfrom
kurama:fix/beat-pill-shape

Conversation

@kurama
Copy link
Copy Markdown
Contributor

@kurama kurama commented Nov 28, 2025

📋 Overview

What problem does this pull request address?

After optimizing the beat changes in a canvas, their shape was not correct.

What features or functionality does this pull request introduce or enhance?

The border radius of the beats is now calculated dynamically.

🛠️ Type of change

  • 🐛 Bugfix (a non-breaking change that resolves an issue)
  • ✨ New feature (a non-breaking change that adds new functionality)
  • ⚠️ Breaking change (a fix or feature that alters existing functionality in a way that could cause issues)
  • 🎨 User Interface (UI) updates
  • 📄 New Documentation (addition of new documentation)
  • 📄 Documentation Update (modification of existing documentation)
  • 📄 Documentation Update Required (the change requires updates to related documentation)
  • 🔧 Other (please specify):
    • Provide additional details here.

📄 Checklist

  • 🔍 My code adheres to the style guidelines of this project.
  • 🦿 I have indicated where (if any) I used an LLM for the contributions
  • ✅ I ran ESLint and other code linters for modified files.
  • 🛠️ I have reviewed and tested my code.
  • 📝 I have commented my code, especially in hard-to-understand areas (e.g., using JSDoc for methods).
  • ⚠️ My changes generate no new warnings.
  • 🤖 My code needed automated testing. I have added them (this is an optional task).
  • 📄 Documentation updates are included (if applicable).
  • 🔒 I have considered potential security impacts and mitigated risks.
  • 🧰 Dependency updates are listed and explained.
  • 📚 I have read and understood the Pull Request guidelines.

📷 Screenshots or Visual Changes

  • UI Modifications: Highlight any changes made to the user interface.
  • Before & After: Include screenshots or comparisons (if applicable).

Before:

image

After:

image
Event Before After
UP Before After
DOWN Before After
Certificate-expiry Before After
Testing Before After

Copilot AI review requested due to automatic review settings November 28, 2025 08:14
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes the beat border radius calculation in the HeartbeatBar component to ensure beats maintain their proper pill shape after canvas rendering optimizations introduced in PR #6407.

  • Removes the static beatBorderRadius property from the component's data
  • Implements dynamic border radius calculation based on beat width (width / 2)
  • Ensures pill shapes scale correctly during hover states

@kurama kurama changed the title fix: dynamically adjust beat border radius for beat fix: dynamically adjust beat border radius Nov 28, 2025
Copy link
Copy Markdown
Collaborator

@CommanderStorm CommanderStorm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thank you!

I totally forgot to check this case during my testing

@CommanderStorm CommanderStorm merged commit 70329cc into louislam:master Nov 28, 2025
25 checks passed
@CommanderStorm CommanderStorm added this to the 2.1.0 milestone Dec 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Found some issues in nightly2

3 participants