fix: redraw HeartbeatBar canvas on theme change & update empty beat color#6435
Merged
CommanderStorm merged 3 commits intolouislam:masterfrom Nov 28, 2025
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a theme synchronization issue where the HeartbeatBar canvas did not update when switching between light and dark themes, causing empty beats to retain their previous theme's colors until a hover or new beat event triggered a redraw.
Key Changes:
- Added a
$root.themewatcher to trigger canvas redraw on theme changes - Introduced
--beat-empty-colorCSS variable with theme-specific values (#f0f8ff for light, #848484 for dark) - Refactored color retrieval to use both root and component-scoped styles for proper theme support
CommanderStorm
approved these changes
Nov 28, 2025
Collaborator
CommanderStorm
left a comment
There was a problem hiding this comment.
LGTM, thank you for this work and sorry for not spotting this beforehand.
As soon as the Copilot comment is resolved, we can merge.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…olor
❗ Important Announcements
Click here for more details:
🚫 Please Avoid Unnecessary Pinging of Maintainers
We kindly ask you to refrain from pinging maintainers unless absolutely necessary. Pings are for critical/urgent pull requests that require immediate attention.
📋 Overview
What problem does this pull request address?
HeartbeatBar canvas didn't update when switching between light/dark themes, empty beats kept their previous color until a hover or new beat triggered a redraw. Also the colors wasn't the ones used before the update with canvas.
What features or functionality does this pull request introduce or enhance?
Added $root.theme watcher to trigger canvas redraw on theme change
Moved empty beat colors to CSS variable (--beat-empty-color) for proper theme support
divs with Canvas based rendering #6407🛠️ Type of change
📄 Checklist
📷 Screenshots or Visual Changes
Before
After
UPDOWN