feat: Add XMPP dialog in STARTTLS routine#6508
Merged
CommanderStorm merged 2 commits intolouislam:masterfrom Dec 20, 2025
Merged
feat: Add XMPP dialog in STARTTLS routine#6508CommanderStorm merged 2 commits intolouislam:masterfrom
CommanderStorm merged 2 commits intolouislam:masterfrom
Conversation
CommanderStorm
approved these changes
Dec 20, 2025
Collaborator
CommanderStorm
left a comment
CommanderStorm
left a comment
There was a problem hiding this comment.
I don't have a good idea what I am looking at, but since it has tests I trust you that everythign is correct 😉
Lets merge
CommanderStorm
changed the title
|
Thank you for supporting XMPP! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 Summary of changes done and why they are done
On top of the existing TLS/STARTTLS feature, this PR recognizes and handles XMPP servers.
📋 Related issues
📷 Screenshots or Visual Changes
Not applicable.
Testing
The last case in node
./test/backend-test/test-tcp.jsverifies the feature positively. I could not find a broken XMPP server to test the failing case.