Skip to content

Added a button to reset the status page icon to the default#6533

Merged
CommanderStorm merged 4 commits intolouislam:masterfrom
cyril59310:add-default-icons-status-page
Jan 1, 2026
Merged

Added a button to reset the status page icon to the default#6533
CommanderStorm merged 4 commits intolouislam:masterfrom
cyril59310:add-default-icons-status-page

Conversation

@cyril59310
Copy link
Copy Markdown
Contributor

ℹ️ To keep reviews fast and effective, please make sure you’ve read our pull request guidelines

📝 Summary of changes done and why they are done

  • I added a button that allows setting the default icon for the status page

📋 Related issues

📄 Checklist

Please follow this checklist to avoid unnecessary back and forth (click to expand)
  • ⚠️ If there are Breaking change (a fix or feature that alters existing functionality in a way that could cause issues) I have called them out
  • 🔍 My code adheres to the style guidelines of this project.
  • 🦿 I have indicated where (if any) I used an LLM for the contributions
  • ✅ I ran ESLint and other code linters for modified files.
  • ⚠️ My changes generate no new warnings.
  • 🛠️ I have reviewed and tested my code.
  • 📝 I have commented my code, especially in hard-to-understand areas (e.g., using JSDoc for methods).
  • 🤖 My code needed automated testing. I have added them (this is an optional task).
  • 📄 Documentation updates are included (if applicable).
  • 🔒 I have considered potential security impacts and mitigated risks.
  • 🧰 Dependency updates are listed and explained.

📷 Screenshots or Visual Changes

  • UI Modifications: Highlight any changes made to the user interface.
  • Before & After: Include screenshots or comparisons (if applicable).
CPNtyaIV5uMi.mp4

@jochemp264
Copy link
Copy Markdown
Contributor

Good new feature! I have tried it out and it works perfectly on my installations.
I do think we need to define a proper key for the translation you added in en.json so we can implement in weblate. Suggestion: "imageResetConfirmation"

Copy link
Copy Markdown
Contributor

@jochemp264 jochemp264 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change translation key in en.json to imageResetConfirmation

@cyril59310
Copy link
Copy Markdown
Contributor Author

For short translation keys, it doesn’t change much in my opinion, but it’s still worth doing for better consistency.

Copy link
Copy Markdown
Collaborator

@CommanderStorm CommanderStorm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks.

One comment regarding the icon used. No big oppion from my side, just something "a bit odd".
-> I am fine with both accept/reject on this one.

@CommanderStorm CommanderStorm added this to the 2.1.0 milestone Jan 1, 2026
@CommanderStorm CommanderStorm merged commit d8bd71f into louislam:master Jan 1, 2026
20 checks passed
@cyril59310 cyril59310 deleted the add-default-icons-status-page branch January 1, 2026 21:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants