Skip to content

feat: add "resend" email sending notification provider#6544

Merged
CommanderStorm merged 8 commits intolouislam:masterfrom
lsnnt:master
Dec 31, 2025
Merged

feat: add "resend" email sending notification provider#6544
CommanderStorm merged 8 commits intolouislam:masterfrom
lsnnt:master

Conversation

@lsnnt
Copy link
Copy Markdown
Contributor

@lsnnt lsnnt commented Dec 30, 2025

📝 Summary of changes done and why they are done

The new notification provider is added and also tested using my own domains and api keys

image Screenshot 2025-12-30 at 13 14 07

📋 Related issues

N/A

📄 Checklist

Please follow this checklist to avoid unnecessary back and forth (click to expand)
  • ⚠️ If there are Breaking change (a fix or feature that alters existing functionality in a way that could cause issues) I have called them out
  • 🔍 My code adheres to the style guidelines of this project.
  • 🦿 I have indicated where (if any) I used an LLM for the contributions
  • ✅ I ran ESLint and other code linters for modified files.
  • ⚠️ My changes generate no new warnings.
  • 🛠️ I have reviewed and tested my code.
  • 📝 I have commented my code, especially in hard-to-understand areas (e.g., using JSDoc for methods).
  • 🤖 My code needed automated testing. I have added them (this is an optional task).
  • 📄 Documentation updates are included (if applicable).
  • 🔒 I have considered potential security impacts and mitigated risks.
  • 🧰 Dependency updates are listed and explained.

📷 Screenshots or Visual Changes

N/A

@lsnnt
Copy link
Copy Markdown
Contributor Author

lsnnt commented Dec 30, 2025

One of the CI jobs failed due to a temporary network issue (Connection failed in TCP test).
Could you please re-run the checks?

Copy link
Copy Markdown
Collaborator

@CommanderStorm CommanderStorm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work.

I’d like to see this made resilient against XSS in emails, or alternatively switched to plain-text emails.

More generally, adding templating support could be a nice improvement for the notification provider and shouldn’t require much additional code. That said, if you’d rather not take this on, that’s perfectly fine too.

@CommanderStorm CommanderStorm added the pr:please address review comments this PR needs a bit more work to be mergable label Dec 30, 2025
@lsnnt lsnnt requested a review from CommanderStorm December 31, 2025 05:43
@lsnnt lsnnt requested a review from CommanderStorm December 31, 2025 16:38
Copy link
Copy Markdown
Collaborator

@CommanderStorm CommanderStorm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work, thank you ❤️

@CommanderStorm CommanderStorm changed the title Added "resend" email sending notification provider feat: add "resend" email sending notification provider Dec 31, 2025
@CommanderStorm CommanderStorm merged commit 23a8a40 into louislam:master Dec 31, 2025
20 checks passed
@CommanderStorm CommanderStorm added this to the 2.1.0 milestone Jan 1, 2026
@CommanderStorm CommanderStorm removed the pr:please address review comments this PR needs a bit more work to be mergable label Jan 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants