feat: add "resend" email sending notification provider#6544
Merged
CommanderStorm merged 8 commits intolouislam:masterfrom Dec 31, 2025
Merged
feat: add "resend" email sending notification provider#6544CommanderStorm merged 8 commits intolouislam:masterfrom
CommanderStorm merged 8 commits intolouislam:masterfrom
Conversation
Contributor
Author
|
One of the CI jobs failed due to a temporary network issue (Connection failed in TCP test). |
CommanderStorm
requested changes
Dec 30, 2025
Collaborator
CommanderStorm
left a comment
There was a problem hiding this comment.
Nice work.
I’d like to see this made resilient against XSS in emails, or alternatively switched to plain-text emails.
More generally, adding templating support could be a nice improvement for the notification provider and shouldn’t require much additional code. That said, if you’d rather not take this on, that’s perfectly fine too.
Co-authored-by: Frank Elsinga <frank@elsinga.de>
CommanderStorm
approved these changes
Dec 31, 2025
Collaborator
CommanderStorm
left a comment
There was a problem hiding this comment.
Nice work, thank you ❤️
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 Summary of changes done and why they are done
The new notification provider is added and also tested using my own domains and api keys
📋 Related issues
N/A
📄 Checklist
Please follow this checklist to avoid unnecessary back and forth (click to expand)
📷 Screenshots or Visual Changes
N/A