Skip to content

fix(ci): update OS versions in auto-test workflow to use github hosted instead of selfhosted runners#6567

Merged
louislam merged 9 commits intolouislam:masterfrom
CommanderStorm:CommanderStorm-patch-2
Jan 2, 2026
Merged

fix(ci): update OS versions in auto-test workflow to use github hosted instead of selfhosted runners#6567
louislam merged 9 commits intolouislam:masterfrom
CommanderStorm:CommanderStorm-patch-2

Conversation

@CommanderStorm
Copy link
Copy Markdown
Collaborator

ℹ️ To keep reviews fast and effective, please make sure you’ve read our pull request guidelines

📝 Summary of changes done and why they are done

This fixes https://github.com/louislam/uptime-kuma/security/advisories/GHSA-j2w5-6w25-mcwq

Not sure if it is actually exploitable, but better be sure.
CC @zaddy6

Copilot AI review requested due to automatic review settings January 2, 2026 01:15
@CommanderStorm CommanderStorm changed the title fix(sec): Update OS versions in auto-test workflow fix(sec): update OS versions in auto-test workflow Jan 2, 2026
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR addresses a security advisory (GHSA-j2w5-6w25-mcwq) by updating the OS versions used in the auto-test GitHub Actions workflow to more recent versions.

Key changes:

  • Updated Ubuntu runner from version 22.04 to 24.04
  • Changed ARM64 runner reference to use the standard ubuntu-24.04-arm label

@CommanderStorm CommanderStorm force-pushed the CommanderStorm-patch-2 branch from fe2b174 to 04bd256 Compare January 2, 2026 02:36
@CommanderStorm CommanderStorm changed the title fix(sec): update OS versions in auto-test workflow fix(sec): update OS versions in auto-test workflow to use github hosted instead of selfhosted runners Jan 2, 2026
@CommanderStorm
Copy link
Copy Markdown
Collaborator Author

@louislam merging needs a change in the repo settings as the runners seem to be hardcoded there.

We can also add a job like this

  # This final step is needed to mark the whole workflow as successful
  # Don't change its name - it is used by the merge protection rules
  done:
    name: CI Finished
    runs-on: ubuntu-latest
    needs: [ armv7-simple-tests, auto-test, e2e-test ]
    if: always()
    permissions: {}
    steps:
      - name: Result of the needed steps
        run: echo "${{ toJSON(needs) }}" # zizmor: ignore[template-injection]
      - if: ${{ contains(needs.*.result, 'failure') || contains(needs.*.result, 'cancelled') || contains(needs.*.result, 'skipped') }}
        name: CI Result
        run: exit 1

@CommanderStorm CommanderStorm added this to the 2.1.0 milestone Jan 2, 2026
@CommanderStorm CommanderStorm changed the title fix(sec): update OS versions in auto-test workflow to use github hosted instead of selfhosted runners fix(ci): update OS versions in auto-test workflow to use github hosted instead of selfhosted runners Jan 2, 2026
@louislam louislam disabled auto-merge January 2, 2026 04:40
@louislam
Copy link
Copy Markdown
Owner

louislam commented Jan 2, 2026

I think we still need to change to pull_request_target, as suggested in GHSA-j2w5-6w25-mcwq.

Let me also update the required workflow, in order to pass all checks.

@CommanderStorm
Copy link
Copy Markdown
Collaborator Author

CommanderStorm commented Jan 2, 2026

I think we still need to change to pull_request_target, as suggested in GHSA-j2w5-6w25-mcwq.

Let me also update the required workflow, in order to pass all checks.

I am not sure where you are reading this in https://github.com/louislam/uptime-kuma/security/advisories/GHSA-j2w5-6w25-mcwq

In fact, @zaddy6 explicitely warns against this.

Replace pull_request with pull_request_target ONLY when:

  • No untrusted code is checked out
  • No build/test steps execute contributor code

-> Lets stick with pull_request trigger. Neither of these two are possible for tests.

@louislam louislam merged commit 1d0415f into louislam:master Jan 2, 2026
20 checks passed
@louislam
Copy link
Copy Markdown
Owner

louislam commented Jan 2, 2026

Actually, I don't quite understand that recommended fixes, but now we don't have self-hosted runners anymore, I think I don't need to understand it haha. Thanks for the pr.

@CommanderStorm CommanderStorm deleted the CommanderStorm-patch-2 branch January 2, 2026 05:11
@CommanderStorm
Copy link
Copy Markdown
Collaborator Author

The fixes are mostly removing things that were nessesary for the self hosted runners (such as needs).

I chose to use quemu which works resonably well for the armv7 check.

The pipeline is faster since we don't need to wait for the central self-hosted runner and can use our 20 runners. (we are currently not using all)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants