feat: label the min, avg, max on the dashboad ping chart and make them selectable#6573
Merged
CommanderStorm merged 8 commits intolouislam:masterfrom Jan 2, 2026
Merged
Conversation
CommanderStorm
approved these changes
Jan 2, 2026
Collaborator
CommanderStorm
left a comment
There was a problem hiding this comment.
Works nicely.
Can we include the new text in the on-hover label too while we are at it?
That label is currently just the time.
If not, also fine
| return ds && ds.type !== "bar"; | ||
| }, | ||
| callbacks: { | ||
| label: (context) => { |
Collaborator
There was a problem hiding this comment.
I think if we adjust the line below this comment, we even get the new Legent to be incuded in the label 🤔
This way, we fix 100% of the issue and not just 95% of it.
I have not looked into if this is difficult (=what is included in context), but if it is not we should do it.
Contributor
Author
Collaborator
|
thank you ❤️ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

ℹ️ To keep reviews fast and effective, please make sure you’ve read our pull request guidelines
📝 Summary of changes done and why they are done
📋 Related issues
📄 Checklist
Please follow this checklist to avoid unnecessary back and forth (click to expand)
📷 Screenshots or Visual Changes