Skip to content

feat: label the min, avg, max on the dashboad ping chart and make them selectable#6573

Merged
CommanderStorm merged 8 commits intolouislam:masterfrom
cyril59310:Chart-improvement
Jan 2, 2026
Merged

feat: label the min, avg, max on the dashboad ping chart and make them selectable#6573
CommanderStorm merged 8 commits intolouislam:masterfrom
cyril59310:Chart-improvement

Conversation

@cyril59310
Copy link
Copy Markdown
Contributor

ℹ️ To keep reviews fast and effective, please make sure you’ve read our pull request guidelines

📝 Summary of changes done and why they are done

  • I improved the UX to make the chart more clear and added the ability to show or hide each line: minPing, maxPing, and avgPing

📋 Related issues

📄 Checklist

Please follow this checklist to avoid unnecessary back and forth (click to expand)
  • ⚠️ If there are Breaking change (a fix or feature that alters existing functionality in a way that could cause issues) I have called them out
  • 🔍 My code adheres to the style guidelines of this project.
  • 🦿 I have indicated where (if any) I used an LLM for the contributions
  • ✅ I ran ESLint and other code linters for modified files.
  • ⚠️ My changes generate no new warnings.
  • 🛠️ I have reviewed and tested my code.
  • 📝 I have commented my code, especially in hard-to-understand areas (e.g., using JSDoc for methods).
  • 🤖 My code needed automated testing. I have added them (this is an optional task).
  • 📄 Documentation updates are included (if applicable).
  • 🔒 I have considered potential security impacts and mitigated risks.
  • 🧰 Dependency updates are listed and explained.

📷 Screenshots or Visual Changes

  • UI Modifications: Highlight any changes made to the user interface.
  • Before & After: Include screenshots or comparisons (if applicable).
image

0q5p3Uw1dKf4

@CommanderStorm CommanderStorm changed the title Improvements: Better UX for diagrams in the dashboard feat: label the min, avg, max on the dashboad and make them selectable Jan 2, 2026
Copy link
Copy Markdown
Collaborator

@CommanderStorm CommanderStorm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works nicely.
Can we include the new text in the on-hover label too while we are at it?
That label is currently just the time.

If not, also fine

return ds && ds.type !== "bar";
},
callbacks: {
label: (context) => {
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think if we adjust the line below this comment, we even get the new Legent to be incuded in the label 🤔

This way, we fix 100% of the issue and not just 95% of it.
I have not looked into if this is difficult (=what is included in context), but if it is not we should do it.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

An addition I also wanted to make, but had forgotten, has now been implemented
image

@CommanderStorm CommanderStorm changed the title feat: label the min, avg, max on the dashboad and make them selectable feat: label the min, avg, max on the dashboad ping chart and make them selectable Jan 2, 2026
@CommanderStorm CommanderStorm merged commit 9a5bcf1 into louislam:master Jan 2, 2026
20 checks passed
@CommanderStorm CommanderStorm added this to the 2.1.0 milestone Jan 2, 2026
@CommanderStorm
Copy link
Copy Markdown
Collaborator

thank you ❤️

@cyril59310 cyril59310 deleted the Chart-improvement branch January 2, 2026 23:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Better UX explainng what the max, min, avg in the dashboard diagrams are

2 participants