Skip to content

fix(docker): make docker more robust towards pausing,restarts, missing healtchecks and missing container states#6584

Merged
CommanderStorm merged 8 commits intolouislam:masterfrom
CommanderStorm:CommanderStorm-patch-2
Jan 5, 2026
Merged

fix(docker): make docker more robust towards pausing,restarts, missing healtchecks and missing container states#6584
CommanderStorm merged 8 commits intolouislam:masterfrom
CommanderStorm:CommanderStorm-patch-2

Conversation

@CommanderStorm
Copy link
Copy Markdown
Collaborator

@CommanderStorm CommanderStorm commented Jan 5, 2026

ℹ️ To keep reviews fast and effective, please make sure you’ve read our pull request guidelines

📝 Summary of changes done and why they are done

Tries to fix #6292 (comment)

@mayberryjp @benji2k2 @bondskin could you test this PR?
Instructions for how to test PRs are here:

https://github.com/louislam/uptime-kuma/wiki/Test-Pull-Requests

📋 Related issues

Copilot AI review requested due to automatic review settings January 5, 2026 07:36
@CommanderStorm CommanderStorm added this to the 2.1.0 milestone Jan 5, 2026

This comment was marked as resolved.

@CommanderStorm CommanderStorm added the releaseblocker 🚨 blocking bugs encountered with a new release label Jan 5, 2026
CommanderStorm and others added 3 commits January 5, 2026 08:40
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@louislam louislam linked an issue Jan 5, 2026 that may be closed by this pull request
1 task
@benji2k2
Copy link
Copy Markdown
Contributor

benji2k2 commented Jan 5, 2026

In general the changes should work but they change the behaviour in some cases. In example containers without a health-state stay „PENDING“ instead of being „UP“ like before. In my opinion the most „minimal invasive“ solution solving the original problem with „unhealthy“ containers was my original pr (31eaf2d). This should only solve the original problem and does not have any side-effects in other cases (it is running here on 3 servers without any problems for three months). Maybe you think about using this solution to avoid other problems.

@benji2k2
Copy link
Copy Markdown
Contributor

benji2k2 commented Jan 5, 2026

@CommanderStorm This should restore the old behavior for containers without health state. I tested the PR and it is working for running, paused, healthy and unhealthy containers. I cannot test it for the case without health-status and for restarting containers in my setup. but looks good so far.

@CommanderStorm
Copy link
Copy Markdown
Collaborator Author

Works for me, lets merge

@CommanderStorm
Copy link
Copy Markdown
Collaborator Author

FYI: If we migrate this monitor to the newer monitor condition way of building them, this would enable writing testcases for this monitor and prevent issues like this

@CommanderStorm CommanderStorm merged commit e7aeb2e into louislam:master Jan 5, 2026
23 checks passed
@CommanderStorm CommanderStorm removed the releaseblocker 🚨 blocking bugs encountered with a new release label Jan 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Container monitoring in 2.1.0-beta.1 includes breaking change

3 participants