chore: make more translation keys avaliable#6589
Merged
CommanderStorm merged 13 commits intolouislam:masterfrom Jan 6, 2026
Merged
chore: make more translation keys avaliable#6589CommanderStorm merged 13 commits intolouislam:masterfrom
CommanderStorm merged 13 commits intolouislam:masterfrom
Conversation
…the chance to differentiate between them
Contributor
There was a problem hiding this comment.
Pull request overview
This PR improves internationalization (i18n) by making hardcoded English strings translatable. It fixes inconsistencies where time periods were displayed as "24-hour", "30-day", and "1-year" instead of the more natural "24 hours", "30 days", and "1 year" by implementing proper pluralization. Additionally, it makes various accessibility attributes (aria-labels and alt text) translatable.
Key changes:
- Replaces hardcoded time period keys (
-hour,-day,-year) with pluralized translation keys (hour | hours,day | days,year | years) - Converts static aria-label and alt attributes across 13 Vue components to use dynamic translations
- Updates Confirm.vue component to use translatable defaults for "Yes" and "No" buttons
Reviewed changes
Copilot reviewed 17 out of 17 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| src/pages/Details.vue | Updated uptime display labels to use pluralized time period translations (24 hours, 30 days, 1 year) |
| src/components/Uptime.vue | Updated title computation to use pluralized time period translations |
| src/lang/en.json | Added pluralization support for "hour" and "year", added accessibility text keys, removed old non-pluralized time period keys |
| src/pages/SetupDatabase.vue | Made aria-label translatable for radio button group |
| src/components/settings/Appearance.vue | Made aria-labels translatable for two checkbox toggle button groups |
| src/components/TwoFADialog.vue | Made Close button aria-label translatable |
| src/components/TagEditDialog.vue | Made Close button aria-label translatable |
| src/components/ScreenshotDialog.vue | Made Close button aria-label and image alt text translatable |
| src/components/RemoteBrowserDialog.vue | Made Close button aria-label translatable |
| src/components/ProxyDialog.vue | Made Close button aria-label translatable |
| src/components/NotificationDialog.vue | Made Close button aria-label translatable |
| src/components/MonitorSettingDialog.vue | Made Close button aria-label translatable |
| src/components/DockerHostDialog.vue | Made Close button aria-label translatable |
| src/components/CreateGroupDialog.vue | Made Close button aria-label translatable |
| src/components/Confirm.vue | Made Close button aria-label translatable and converted "Yes"/"No" default prop values to use translations |
| src/components/BadgeGeneratorDialog.vue | Made Close button aria-label translatable |
| src/components/APIKeyDialog.vue | Made Close button aria-labels translatable in both modals |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ℹ️ To keep reviews fast and effective, please make sure you’ve read our pull request guidelines
📝 Summary of changes done and why they are done
This PR fixes a few of the deeper/less noticable bugs regarding to translations, such as having "30-day" insted of "30 days" in a few places (with our translators not getting a clue which is correct)
I tested all of them manually, so this is Fine