feat: extract MySQL/MariaDB monitor to its own monitor-type and enable support conditions#6601
Conversation
|
Hi @CommanderStorm would you review this PR? this was easy as you shared the reference PR and guide |
CommanderStorm
left a comment
There was a problem hiding this comment.
Really nice work, there are two things which I apparently did not notice during the sqlserver PR. Both are super simple to fix.
Could you maybe also fix them for the sqlserver impl since they are both extremely simple to fix
Would you review my update for mysql first? before I move to sqlserver? |
e1b0cbb to
e206cd9
Compare
CommanderStorm
left a comment
There was a problem hiding this comment.
a bit of lightly appliable diff, nothing major
…e conditions support
Co-authored-by: Frank Elsinga <frank@elsinga.de>
Co-authored-by: Frank Elsinga <frank@elsinga.de>
Co-authored-by: Frank Elsinga <frank@elsinga.de>
cbe81e0 to
32456d3
Compare
|
@CommanderStorm finally I push the commit for mssql changes, please review again for last commit 😉 |
|
the test fails are the another flakes... still good to merge? |
|
Okay... CI is failing.. But it is in this PRs Tests, so luckily no flake. |
Thank you, good night! |
Head branch was pushed to by a user without write access
|
@CommanderStorm would you enable auto merge again? I pushed the fix for testing |
server/monitor-types/mssql.js
Outdated
|
|
||
| let result; | ||
| const conditions = ConditionExpressionGroup.fromMonitor(monitor); | ||
| const hasConditions = conditions !== null; |
There was a problem hiding this comment.
This seems a bit sus, since the other instance of hasConditions in the codebase does this slightly differently.
Will need to manually verify which version is correct tomorrow.
Good night

📝 Summary of changes done and why they are done
monitor.jsto its own monitor-type file (server/monitor-types/mysql.js)resultvariable for query result validation📋 Related issues
📄 Checklist
Please follow this checklist to avoid unnecessary back and forth (click to expand)
I understand that I am responsible for and able to explain every line of code I submit.
📷 Screenshots or Visual Changes
Contribution by Gittensor, see my contribution statistics at https://gittensor.io/miners/details?githubId=42954461