Skip to content

feat(serwersms): add group messaging support#6610

Merged
CommanderStorm merged 4 commits intolouislam:masterfrom
MkDev11:serwersms-group-messaging
Jan 6, 2026
Merged

feat(serwersms): add group messaging support#6610
CommanderStorm merged 4 commits intolouislam:masterfrom
MkDev11:serwersms-group-messaging

Conversation

@MkDev11
Copy link
Copy Markdown
Contributor

@MkDev11 MkDev11 commented Jan 6, 2026

📝 Summary of changes done and why they are done

Adds group messaging support to the SerwerSMS notification provider.

Currently, SerwerSMS only allows sending notifications to a single phone number. However, the SerwerSMS API already supports sending messages to predefined groups. This change exposes that capability in the UI, letting users choose whether to send to a phone number or a group.

What changed:

  • Added a "Recipient type" dropdown with options for "Phone number" (default) or "Group"
  • The phone number field appears when "Phone number" is selected
  • A new group ID field appears when "Group" is selected
  • Backend conditionally sends either the phone or group parameter to the API

This is a non-breaking change — existing notifications using phone numbers continue to work as before.

📋 Related issues

📄 Checklist

Please follow this checklist to avoid unnecessary back and forth (click to expand)
  • ⚠️ If there are Breaking change (a fix or feature that alters existing functionality in a way that could cause issues) I have called them out
  • 🧠 I have disclosed any use of LLMs/AI in this contribution and reviewed all generated content.
    I understand that I am responsible for and able to explain every line of code I submit.
  • 🔍 My code adheres to the style guidelines of this project.
  • ⚠️ My changes generate no new warnings.
  • 🛠️ I have reviewed and tested my code.
  • 📝 I have commented my code, especially in hard-to-understand areas (e.g., using JSDoc for methods).
  • 🤖 I added or updated automated tests where appropriate.
  • 📄 Documentation updates are included (if applicable).
  • 🔒 I have considered potential security impacts and mitigated risks.
  • 🧰 Dependency updates are listed and explained.

📷 Screenshots or Visual Changes

  • UI Modifications: Added recipient type dropdown and conditional group ID field
    | Phone number | Group |
    |--------------|-------|
    | phone number | group |

Files changed:

  • server/notification-providers/serwersms.js — Backend logic to send group param when group is selected
  • src/components/notifications/SerwerSMS.vue — UI with recipient type dropdown and conditional fields
  • src/lang/en.json — Added translation keys for new UI elements

Contribution by Gittensor, see my contribution statistics at https://gittensor.io/miners/details?githubId=94194147

Adds the ability to send notifications to a SerwerSMS group instead of
just a single phone number. Users can now choose between 'Phone number'
or 'Group' as the recipient type.

- Add recipient type dropdown in UI
- Conditionally show phone number or group ID field
- Backend sends 'group' param instead of 'phone' when group is selected
- Add translation keys for new UI elements

Fixes louislam#6000
@MkDev11
Copy link
Copy Markdown
Contributor Author

MkDev11 commented Jan 6, 2026

@louislam @CommanderStorm Please review the PR and let me know your feedbacks.

Copy link
Copy Markdown
Collaborator

@CommanderStorm CommanderStorm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM.
Could you share a screenshot of a notification being send succssfully to a group?

We can merge if I have a screenshot that it works 😉
This is especailly since https://dev.serwersms.pl/en/https-api-v2/sending-sms-messages-with-the-same-content does not show the group key only group_id

@CommanderStorm CommanderStorm added the pr:please address review comments this PR needs a bit more work to be mergable label Jan 6, 2026
@CommanderStorm CommanderStorm marked this pull request as draft January 6, 2026 16:51
Per SerwerSMS API docs, the parameter for group messaging is 'group_id',
not 'group'.
- Add help text for group ID field with detailed description
- Help text explains how to find group IDs in Customer Panel
@MkDev11
Copy link
Copy Markdown
Contributor Author

MkDev11 commented Jan 6, 2026

Code LGTM. Could you share a screenshot of a notification being send succssfully to a group?

We can merge if I have a screenshot that it works 😉 This is especailly since https://dev.serwersms.pl/en/https-api-v2/sending-sms-messages-with-the-same-content does not show the group key only group_id

Since the platform requires a company email address, it's hard for me to share the screenshot.

@CommanderStorm CommanderStorm marked this pull request as ready for review January 6, 2026 17:07
Copilot AI review requested due to automatic review settings January 6, 2026 17:07
Copy link
Copy Markdown
Collaborator

@CommanderStorm CommanderStorm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since the docs are fairly good on this one, I am inclided to accept it without the usual screenshot that we require for all notification providers

@CommanderStorm CommanderStorm enabled auto-merge (squash) January 6, 2026 17:09
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds group messaging support to the SerwerSMS notification provider, allowing users to send notifications to predefined groups in addition to individual phone numbers. This is a non-breaking enhancement that maintains backward compatibility with existing phone number-based notifications.

Key changes:

  • Added UI toggle between "Phone number" and "Group" recipient types
  • Conditional form fields display appropriate input based on selection
  • Backend logic sends either phone or group_id parameter to the API accordingly

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

File Description
src/lang/en.json Added translation keys for recipient type selector and group ID field with help text
src/components/notifications/SerwerSMS.vue Added recipient type dropdown and conditional rendering for phone number vs group ID input fields
server/notification-providers/serwersms.js Updated backend logic to conditionally send phone or group_id parameter based on recipient type

@CommanderStorm CommanderStorm merged commit b1355c6 into louislam:master Jan 6, 2026
29 checks passed
@CommanderStorm CommanderStorm added this to the 2.1.0 milestone Jan 6, 2026
@CommanderStorm CommanderStorm removed the pr:please address review comments this PR needs a bit more work to be mergable label Jan 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

SerwerSMS (notification provider) Adding Group Messaging Functionality

3 participants