feat: add UPTIME_KUMA_DB_PASSWORD_FILE and UPTIME_KUMA_DB_USERNAME_FILE for docker secrets control#6629
Conversation
|
@CommanderStorm would you review my PR? I hope this fits the requirement of issue |
|
|
||
| if (fileValue) { | ||
| try { | ||
| return fs.readFileSync(fileValue, "utf8").trim(); |
There was a problem hiding this comment.
is trimming here a good idea? 🤔
Could you add a code comment why this is what we want?
There was a problem hiding this comment.
@CommanderStorm I tried to make sure to remove all spaces, let me remove that
Other than that, all looks good?
There was a problem hiding this comment.
this was not a "this is a bad idea", this was a "does docker secrets have \n line endings if you enter a password?"
There was a problem hiding this comment.
okay, so I would update for \n case, right?
There was a problem hiding this comment.
does docker secrets have \n (or similar) file endings if you enter a password without that?
There was a problem hiding this comment.
Yes, Docker secrets typically include trailing \n characters, even if you didn't intend to add one.
Please review this, so I'd like to keep the trim to prevent
CommanderStorm
changed the title
UPTIME_KUMA_DB_PASSWORD_FILE and UPTIME_KUMA_DB_USERNAME_FILE for docker secrets control
2 participants
ℹ️ To keep reviews fast and effective, please make sure you’ve read our pull request guidelines
📝 Summary of changes done and why they are done
📋 Related issues
📄 Checklist
Please follow this checklist to avoid unnecessary back and forth (click to expand)
I understand that I am responsible for and able to explain every line of code I submit.
📷 Screenshots or Visual Changes
UPDOWNContribution by Gittensor, see my contribution statistics at https://gittensor.io/miners/details?githubId=42954461