Skip to content

chore: improve misc i18n things#6645

Merged
CommanderStorm merged 9 commits intolouislam:masterfrom
CommanderStorm:misc-i18n
Jan 8, 2026
Merged

chore: improve misc i18n things#6645
CommanderStorm merged 9 commits intolouislam:masterfrom
CommanderStorm:misc-i18n

Conversation

@CommanderStorm
Copy link
Copy Markdown
Collaborator

No description provided.

Copilot AI review requested due to automatic review settings January 8, 2026 11:46
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR improves internationalization (i18n) by converting several hardcoded string concatenations to proper parameterized translations using Vue i18n's i18n-t component and named parameters. The changes make translations more flexible and easier to maintain across different languages.

  • Converts error message concatenations to use named parameters in EditMonitor.vue
  • Updates translation keys to use named parameters instead of positional ones
  • Refactors inline text with embedded HTML to use i18n-t component with named template slots
  • Removes trailing spaces from translation strings and cleans up unused translation keys

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.

File Description
src/pages/EditMonitor.vue Converts JSON validation error messages to use named parameter {error} instead of string concatenation
src/lang/en.json Updates translation keys to use named parameters ({error}, {url}, {service}, {comma}, {semicolon}), removes trailing spaces, and removes unused keys
src/components/settings/General.vue Refactors Steam API key description to use i18n-t component with #url template slot
src/components/notifications/SMSManager.vue Refactors help text and pricing information to use i18n-t component with named template slots

@louislam
Copy link
Copy Markdown
Owner

louislam commented Jan 8, 2026

In my opinion, better don't add placeholders ({var}) to any existing keys, because we need to update all language files in order to handle it. Otherwise, it may show empty values for non-English.

But due to Weblate conflict issue, you have to update on Weblate, which may take a lot of time to update.

If it is really necessary, please create other property names, and let other contributors to translate.

CommanderStorm and others added 2 commits January 8, 2026 20:51
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@CommanderStorm CommanderStorm enabled auto-merge (squash) January 8, 2026 20:09
@CommanderStorm CommanderStorm added this to the 2.1.0 milestone Jan 8, 2026
@CommanderStorm CommanderStorm merged commit 78020b0 into louislam:master Jan 8, 2026
23 checks passed
MkDev11 pushed a commit to MkDev11/uptime-kuma that referenced this pull request Jan 9, 2026
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
CommanderStorm added a commit to CommanderStorm/uptime-kuma that referenced this pull request Jan 9, 2026
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants