chore: make the monitors consistently log using this.name where appropriate#6651
Merged
CommanderStorm merged 3 commits intolouislam:masterfrom Jan 8, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR standardizes monitor logging to use this.name instead of hardcoded strings, improving consistency across monitor types. Additionally, it removes debug code and refactors Chromium installation logic.
Key changes:
- Replaced hardcoded log module names with
this.namereference for SNMP, PostgreSQL, and MQTT monitors - Removed a debug
console.logstatement - Extracted Chromium installation into a separate well-documented function
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| server/monitor-types/snmp.js | Changed log.debug to use this.name instead of hardcoded "monitor" string |
| server/monitor-types/real-browser-monitor-type.js | Removed debug console.log, changed log.debug calls to use "chromium", and refactored Chromium installation into a separate function |
| server/monitor-types/postgres.js | Changed log.debug to use this.name instead of hardcoded "postgres" string |
| server/monitor-types/mqtt.js | Changed all log.debug calls to use this.name instead of hardcoded "mqtt" string |
MkDev11
pushed a commit
to MkDev11/uptime-kuma
that referenced
this pull request
Jan 9, 2026
CommanderStorm
added a commit
to CommanderStorm/uptime-kuma
that referenced
this pull request
Jan 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ℹ️ To keep reviews fast and effective, please make sure you’ve read our pull request guidelines
📝 Summary of changes done and why they are done
This PR changes the monitors to more conistently log who they are.