Skip to content

chore: make the monitors consistently log using this.name where appropriate#6651

Merged
CommanderStorm merged 3 commits intolouislam:masterfrom
CommanderStorm:more-cosistent-monitor-logging
Jan 8, 2026
Merged

chore: make the monitors consistently log using this.name where appropriate#6651
CommanderStorm merged 3 commits intolouislam:masterfrom
CommanderStorm:more-cosistent-monitor-logging

Conversation

@CommanderStorm
Copy link
Copy Markdown
Collaborator

ℹ️ To keep reviews fast and effective, please make sure you’ve read our pull request guidelines

📝 Summary of changes done and why they are done

This PR changes the monitors to more conistently log who they are.

Copilot AI review requested due to automatic review settings January 8, 2026 21:29
@CommanderStorm CommanderStorm enabled auto-merge (squash) January 8, 2026 21:29
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR standardizes monitor logging to use this.name instead of hardcoded strings, improving consistency across monitor types. Additionally, it removes debug code and refactors Chromium installation logic.

Key changes:

  • Replaced hardcoded log module names with this.name reference for SNMP, PostgreSQL, and MQTT monitors
  • Removed a debug console.log statement
  • Extracted Chromium installation into a separate well-documented function

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.

File Description
server/monitor-types/snmp.js Changed log.debug to use this.name instead of hardcoded "monitor" string
server/monitor-types/real-browser-monitor-type.js Removed debug console.log, changed log.debug calls to use "chromium", and refactored Chromium installation into a separate function
server/monitor-types/postgres.js Changed log.debug to use this.name instead of hardcoded "postgres" string
server/monitor-types/mqtt.js Changed all log.debug calls to use this.name instead of hardcoded "mqtt" string

@CommanderStorm CommanderStorm merged commit 5accda3 into louislam:master Jan 8, 2026
23 checks passed
MkDev11 pushed a commit to MkDev11/uptime-kuma that referenced this pull request Jan 9, 2026
CommanderStorm added a commit to CommanderStorm/uptime-kuma that referenced this pull request Jan 9, 2026
@CommanderStorm CommanderStorm added this to the 2.1.0 milestone Jan 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants