Merged
Conversation
d8da480 to
0664642
Compare
CommanderStorm
requested changes
Jan 9, 2026
Collaborator
CommanderStorm
left a comment
There was a problem hiding this comment.
could you add a test so that the ping monitor does not backslides on this?
Contributor
Author
This pr will also fix issue #3929
|
louislam
requested changes
Jan 10, 2026
Owner
louislam
left a comment
There was a problem hiding this comment.
I think your last manual test was not testing ping monitor?
c5d662b to
286bd73
Compare
0c20f0f to
261d772
Compare
CommanderStorm
approved these changes
Jan 11, 2026
Collaborator
CommanderStorm
left a comment
There was a problem hiding this comment.
From my side this LGTM now.
It needs an approval from louis for a merge
Contributor
Author
I had already pushed an update when I noticed your message. |
Removed unconditionally stripping of brackets from destAddr.
Removed IDN to punycode conversion for hostname.
louislam
approved these changes
Jan 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


ℹ️ To keep reviews fast and effective, please make sure you’ve read our pull request guidelines
📝 Summary of changes done and why they are done
The purpose of this PR is to allow for adding Ping type monitors with IDN domains.
To achieve this, I have added IDN translation by calling URL(address) and extracting the hostname from the result.
During testing, I became aware of the URL call imposes square brackes around IPv6 addresses.
I have therefore added a block that remove those bracket to make it compatible with a shell ping command.
I have also added a similar IDN translation to the defaultFriendlyName function for monitor.hostname in EditMonitor.js.
This change will show the punycode in the Friendly Name input field in other hostname related monitor types like it is done for the HTTP(s) monitor types.
📋 Related issues
📄 Checklist
Please follow this checklist to avoid unnecessary back and forth (click to expand)
I understand that I am responsible for and able to explain every line of code I submit.
📷 Screenshots or Visual Changes
Punycode will show in the Friendly Name fields for hostname related monitors the same way as HTTP(s) monitor types
There are no other visible changes to the user interface