chore: remove timeouts from our unittests#6674
Merged
CommanderStorm merged 2 commits intolouislam:masterfrom Jan 11, 2026
Merged
chore: remove timeouts from our unittests#6674CommanderStorm merged 2 commits intolouislam:masterfrom
CommanderStorm merged 2 commits intolouislam:masterfrom
Conversation
Removed comments explaining the workflow purpose.
Contributor
There was a problem hiding this comment.
Pull request overview
This PR removes the 15-minute timeout from the auto-test CI job and cleans up introductory workflow comments to address timeout failures occurring in some CI runs.
Changes:
- Removed
timeout-minutes: 15from the auto-test job configuration - Removed introductory comments explaining the workflow's purpose
| @@ -12,7 +9,6 @@ permissions: {} | |||
| jobs: | |||
| auto-test: | |||
| runs-on: ${{ matrix.os }} | |||
There was a problem hiding this comment.
Removing the timeout completely could allow CI jobs to hang indefinitely, consuming GitHub Actions minutes and potentially hiding issues. GitHub Actions has a default maximum timeout of 360 minutes (6 hours) per job, which is excessive for these tests. Consider setting a more generous timeout (e.g., 30 or 45 minutes) instead of removing it entirely, which would address the timeout failures while still providing protection against hanging jobs.
Suggested change
| runs-on: ${{ matrix.os }} | |
| runs-on: ${{ matrix.os }} | |
| timeout-minutes: 45 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is failing on some of our CI runs, so well..