chore: add a test case so that a substantative placeholder changes are appant to contributors#6681
Merged
CommanderStorm merged 3 commits intolouislam:masterfrom Jan 12, 2026
Conversation
…ent to our contributors
Contributor
|
Hello! Thank you for your contribution 👋 As this is your first contribution, please be sure to check out our In particular:
If you have any design or process questions, feel free to ask them right here in this pull request - unclear documentation is a bug too. Thanks for lending a paw to Uptime Kuma 🐻 |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds a test to enforce that changes to translation placeholder parameters in en.json are treated as breaking changes. The test compares the local en.json against the upstream master version to detect when placeholder parameters have been modified, requiring contributors to rename translation keys instead.
Changes:
- Converted file system operations from synchronous to async/promises
- Added a new test that validates translation placeholder parameters haven't changed
- Implemented
extractParamshelper function to parse placeholders from translation strings
CommanderStorm
changed the title
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instead of explaining to people that changing translations in a substantative way is a breaking change, lets just add a test for this