Skip to content

feat: don't show a retry interval without retries enabled#6685

Merged
CommanderStorm merged 1 commit intolouislam:masterfrom
CommanderStorm:no-retry-interval-without-maxretries
Jan 12, 2026
Merged

feat: don't show a retry interval without retries enabled#6685
CommanderStorm merged 1 commit intolouislam:masterfrom
CommanderStorm:no-retry-interval-without-maxretries

Conversation

@CommanderStorm
Copy link
Copy Markdown
Collaborator

It just does not make sense to show this field if the other is zero

Copilot AI review requested due to automatic review settings January 12, 2026 12:30
@CommanderStorm CommanderStorm enabled auto-merge (squash) January 12, 2026 12:30
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR improves the user experience by hiding the "Heartbeat Retry Interval" field when the "Retries" field is set to 0 or empty. Since the retry interval is only relevant when retries are enabled, conditionally displaying it reduces confusion and form clutter.

Changes:

  • Added conditional rendering to hide the retry interval field when retries are disabled

@CommanderStorm CommanderStorm merged commit 2b2941c into louislam:master Jan 12, 2026
30 checks passed
@CommanderStorm CommanderStorm added this to the 2.1.0 milestone Jan 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants