refactor: simplify filters components#6749
Conversation
|
I put it on two lines because, on mobile, the search bar becomes too small if it's to the right of the filters on some screens. The original design was also on two lines, btw. The filter buttons take up a lot of space. I'll try something else. |
|
Quick question: why use a simple checkbox? Users don't understand its purpose when they first open the application. Furthermore, it's not possible to select just two groups directly; you have to check the checkbox, uncheck it, and then select the two groups. I find this quite cumbersome for a user. Also, having a "Cancel" button that removes the checkboxes doesn't make sense to me. We should have: a "Select monitors" button that displays the checkboxes; if this button is not checked, nothing appears; if it is checked, it displays the checkboxes; a "select all" button; and an "actions" button. |
|
Yes, but the checkboxes are still there. We can't show/hide them on GitHub or even Gmail. I agree that it saves space. |
|
How about we move the "Active" Status into the "Status" filter? For users, these likely feel like the same thing.. |
|
Since this selection feature is fundamentally currently not very usefull (only pause, resume, delete) and does not provide an editing or tagging feature, I think it makes sense to not have it always on and robbing every monitor of vertical space.. |
That's a good idea, I also think that some people don't make the difference, we should choose a color for "running" and "paused" in this case. |
I agree that it's a good idea not to have the checkboxes visible all the time. I simply modified the functionality to make it more user-friendly. When the user arrives, they see a simple checkbox with no information (knowing that no other checkboxes are displayed), which might confuse them. |
|
I'd like to not have such a weirdly placed "select monitors" button that would mean we have to have 3 lines for this. I would like to have 1 line and if we select something, we can have 2 lines. |
|
And on the "users will find it harder", it would be really nice to have some data on this. Currently, I think we are both talking out of personal prefernce, which is not great. |
|
That works! I think for extra intuitiveness, we could add a divider and possibly small versions of the play/pause icons that we use elsewere, but I would be fine with it as-is. |
Great! I'll push that. |
ad3deb9 to
4dc2618
Compare
CommanderStorm
left a comment
There was a problem hiding this comment.
This seems to work much nicer than previus work.
I have three changes:
|
I've pushed two fixes, but I'm not seeing the text blinking. Could you retest and let me know? |
CommanderStorm
left a comment
There was a problem hiding this comment.
Nice work, thank you ❤️
The issue that I was talking about with blinking is that in the light mode, the selection color is white.. on a background which is slightly off-white.
It is a pre-existing issue though, so lets merge this improvement.
Thank you ^^
|
Always a pleasure! Thank you! ❤️ |
|
Not sure if #6820 is related to this pull request. |











Summary
This pull request restructures the monitor list header to improve the layout and responsiveness of the search bar and filter buttons.
Please follow this checklist to avoid unnecessary back and forth (click to expand)
I understand that I am responsible for and able to explain every line of code I submit.
Screenshots for Visual Changes
Before:
After:
UPDOWN