fix: improve RADIUS client error handling and socket cleanup#6783
Merged
CommanderStorm merged 3 commits intolouislam:masterfrom Jan 22, 2026
Merged
Conversation
- Enhanced error messages in util-server.js to preserve stack traces and provide better context with hostname and port information - Fixed potential race conditions in radius-client.js by adding proper socket cleanup and preventing multiple cleanup calls - Added socketClosed flag to prevent operations on closed sockets - Improved timeout handling to prevent memory leaks and ensure proper resource cleanup
Contributor
|
Hello and thanks for lending a paw to Uptime Kuma! 🐻👋 |
Contributor
|
@dive2tech congrats on your first contribution to Uptime Kuma! 🐻 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
This PR improves error handling and resource cleanup in the RADIUS client implementation.
Improvements
Enhanced error messages (
server/util-server.js):Fixed race conditions and memory leaks (
server/radius-client.js):socketClosedflag to prevent operations on closed socketsBenefits
Testing
These changes maintain backward compatibility and improve error handling without changing the API contract.