Skip to content

fix: clearing heartbeats on paused monitors leaves them paused #6897

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
louislam merged 4 commits into from
Feb 18, 2026
+8 −2
Merged

fix: clearing heartbeats on paused monitors leaves them paused #6897

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
d5a4439
Fix: avoid resuming paused monitor when clearing heartbeats
bruce691 Feb 9, 2026
8968b42
Merge branch 'louislam:master' into fix/clear-heartbeats-paused
bruce691 Feb 9, 2026
7432e61
Merge branch 'master' into fix/clear-heartbeats-paused
louislam Feb 18, 2026
64defbf
fix: do not start inactive monitor after cleared stats
louislam Feb 18, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions server/server.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1655,7 +1655,10 @@ let needSetup = false;
await UptimeCalculator.clearStatistics(monitorID);

if (monitorID in server.monitorList) {
await restartMonitor(socket.userID, monitorID);
const monitor = server.monitorList[monitorID];
if (monitor.active) {
await restartMonitor(socket.userID, monitorID);
}
}

await sendHeartbeatList(socket, monitorID, true, true);
Expand All @@ -1681,7 +1684,10 @@ let needSetup = false;

// Restart all monitors to reset the stats
for (let monitorID in server.monitorList) {
await restartMonitor(socket.userID, monitorID);
const monitor = server.monitorList[monitorID];
if (monitor.active) {
await restartMonitor(socket.userID, monitorID);
}
}

callback({
Expand Down
Loading