fix: Add helptext about usage to expiry checkboxes#6978
Merged
CommanderStorm merged 4 commits intomasterfrom Feb 18, 2026
Merged
fix: Add helptext about usage to expiry checkboxes#6978CommanderStorm merged 4 commits intomasterfrom
CommanderStorm merged 4 commits intomasterfrom
Conversation
Co-authored-by: CommanderStorm <26258709+CommanderStorm@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Add help text for expiry notifications configuration
Add helptext to expiry notification checkboxes
Feb 18, 2026
github-actions
bot
added
the
pr:needs review
Contributor
There was a problem hiding this comment.
Pull request overview
Adds explanatory helptext to the monitor edit screen so users understand where to configure the lead time for certificate/domain expiry notifications (in Settings).
Changes:
- Added new i18n keys for certificate/domain expiry notification helptext in
src/lang/en.json - Rendered helptext under the certificate expiry checkbox, and under the domain expiry checkbox when a valid domain is present
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/pages/EditMonitor.vue | Displays the new helptext beneath the relevant expiry-notification checkboxes |
| src/lang/en.json | Adds English translation strings for the helptext |
CommanderStorm
changed the title
| "RadiusCallingStationId": "Calling Station Id", | ||
| "RadiusCallingStationIdDescription": "Identifier of the calling device", | ||
| "Certificate Expiry Notification": "Certificate Expiry Notification", | ||
| "certificateExpiryNotificationHelp": "The number of days in advance can be configured in the Settings.", |
Collaborator
There was a problem hiding this comment.
Suggested change
| "certificateExpiryNotificationHelp": "The number of days in advance can be configured in the Settings.", | |
| "expiryNotificationHelp": "The number of days in advance can be configured in the Settings.", |
| "settingsDomainExpiry": "Domain Expiry", | ||
| "labelDomainExpiry": "Domain Exp.", | ||
| "labelDomainNameExpiryNotification": "Domain Name Expiry Notification", | ||
| "domainExpiryNotificationHelp": "The number of days in advance can be configured in Settings.", |
Collaborator
There was a problem hiding this comment.
Suggested change
| "domainExpiryNotificationHelp": "The number of days in advance can be configured in Settings.", |
Comment on lines
+1494
to
+1496
| <div class="form-text"> | ||
| {{ $t("certificateExpiryNotificationHelp") }} | ||
| </div> |
Collaborator
There was a problem hiding this comment.
Suggested change
| <div class="form-text"> | |
| {{ $t("certificateExpiryNotificationHelp") }} | |
| </div> | |
| <div class="form-text">{{ $t("expiryNotificationHelp") }}</div> |
Comment on lines
+1540
to
+1542
| <div v-if="hasDomain" class="form-text"> | ||
| {{ $t("domainExpiryNotificationHelp") }} | ||
| </div> |
Collaborator
There was a problem hiding this comment.
Suggested change
| <div v-if="hasDomain" class="form-text"> | |
| {{ $t("domainExpiryNotificationHelp") }} | |
| </div> | |
| <div v-if="hasDomain" class="form-text">{{ $t("expiryNotificationHelp") }}</div> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Certificate Expiry Notification and Domain Name Expiry Notification checkboxes lacked context about where to configure the notification timing. Users needed guidance to Settings → Notifications.
Changes
certificateExpiryNotificationHelpanddomainExpiryNotificationHelptosrc/lang/en.jsonsrc/pages/EditMonitor.vue, conditionally shown for domain expiry when a valid domain is presentScreenshot
The helptext reads: "The number of days in advance can be configured in Settings → Notifications."
Original prompt
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.