Skip to content

feat: allow templating in the Signal notificaiton provider#6989

Merged
CommanderStorm merged 4 commits intolouislam:masterfrom
karthikeya-333:templating-in-the-Signal-notificaiton-provider
Feb 19, 2026
Merged

feat: allow templating in the Signal notificaiton provider#6989
CommanderStorm merged 4 commits intolouislam:masterfrom
karthikeya-333:templating-in-the-Signal-notificaiton-provider

Conversation

@karthikeya-333
Copy link
Copy Markdown
Contributor

In this pull request, the following changes are made:

Added custom templating option for Signal notififcation provider.

Backend (server/notification-providers/signal.js):

  • Updated the send() function to correctly handle message text when the custom template option is enabled or disabled for the Signal provider.

Frontend (src/components/notifications/Signal.vue)

  • Added UI support to allow users to toggle the custom message template feature.
  • This aligns Signal with other notification providers where the same feature already exists.

Resolves #6889

Please follow this checklist to avoid unnecessary back and forth (click to expand)
  • ⚠️ If there are Breaking change (a fix or feature that alters existing functionality in a way that could cause issues) I have called them out
  • 🧠 I have disclosed any use of LLMs/AI in this contribution and reviewed all generated content.
    I understand that I am responsible for and able to explain every line of code I submit.
  • 🔍 Any UI changes adhere to visual style of this project.
  • 🛠️ I have self-reviewed and self-tested my code to ensure it works as expected.
  • 📝 I have commented my code, especially in hard-to-understand areas (e.g., using JSDoc for methods).
  • 🤖 I added or updated automated tests where appropriate.
  • 📄 Documentation updates are included (if applicable).
  • 🧰 Dependency updates are listed and explained.
  • ⚠️ CI passes and is green.

Screenshots for Visual Changes

Before:
image

After:
image

@github-actions
Copy link
Copy Markdown
Contributor

Hello and thanks for lending a paw to Uptime Kuma! 🐻👋
As this is your first contribution, please be sure to check out our Pull Request guidelines.
In particular: - Mark your PR as Draft while you’re still making changes - Mark it as Ready for review once it’s fully ready
If you have any design or process questions, feel free to ask them right here in this pull request - unclear documentation is a bug too.

@karthikeya-333 karthikeya-333 changed the title feat:allow templating in the Signal notificaiton provider feat: allow templating in the Signal notificaiton provider Feb 19, 2026
Copy link
Copy Markdown
Collaborator

@CommanderStorm CommanderStorm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me, thanks

@CommanderStorm
Copy link
Copy Markdown
Collaborator

Seems ready, please ping me when you think so too (it is currently a draft).

@karthikeya-333 karthikeya-333 marked this pull request as ready for review February 19, 2026 18:57
@github-actions github-actions bot added the pr:needs review this PR needs a review by maintainers or other community members label Feb 19, 2026
@karthikeya-333
Copy link
Copy Markdown
Contributor Author

Seems ready, please ping me when you think so too (it is currently a draft).

Done, changed it to ready state.

@CommanderStorm CommanderStorm merged commit 019b4b7 into louislam:master Feb 19, 2026
26 checks passed
@github-actions
Copy link
Copy Markdown
Contributor

@karthikeya-333 congrats on your first contribution to Uptime Kuma! 🐻
We hope you enjoy contributing to our project and look forward to seeing more of your work in the future! If you want to see your contribution in action, please see our nightly builds here.

@CommanderStorm CommanderStorm added this to the 2.2.0 milestone Feb 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr:needs review this PR needs a review by maintainers or other community members

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Allow templating in the Signal notificaiton provider

2 participants