fix: show actual bind address in startup logs#6999
Merged
CommanderStorm merged 6 commits intolouislam:masterfrom Feb 23, 2026
Merged
fix: show actual bind address in startup logs#6999CommanderStorm merged 6 commits intolouislam:masterfrom
CommanderStorm merged 6 commits intolouislam:masterfrom
Conversation
When no custom hostname is configured, the server binds to all interfaces (0.0.0.0), but the log message either showed just the port number or 'localhost', which is misleading. Now correctly displays 0.0.0.0 as the bind address.
louislam
requested changes
Feb 20, 2026
Owner
louislam
left a comment
louislam
left a comment
There was a problem hiding this comment.
I don't like 0.0.0.0. Please see my comment in 6956.
Instead of showing 0.0.0.0, list all available URLs similar to Vite dev server: Local: http://localhost:3001 Network: http://192.168.1.100:3001 Applied consistently across server.js, setup-database.js, and simple-migration-server.js
| const nets = networkInterfaces(); | ||
| for (const name of Object.keys(nets)) { | ||
| for (const net of nets[name]) { | ||
| if (!net.internal && net.family === "IPv4") { |
Collaborator
There was a problem hiding this comment.
why the ipv4 check?
We likely should show all the interaces we bound to.
Owner
There was a problem hiding this comment.
also we have function in js. Copy-and-paste is not a good idea, or it is AI code?
- Added printServerUrls() to util-server.js to avoid code duplication - Lists all network addresses (IPv4 + IPv6) like Vite dev server - Applied across server.js, setup-database.js, and simple-migration-server.js
- Remove unused 'log' import in simple-migration-server.js - Add @returns {void} to printServerUrls JSDoc in util-server.js
CommanderStorm
approved these changes
Feb 23, 2026
Collaborator
CommanderStorm
left a comment
CommanderStorm
left a comment
There was a problem hiding this comment.
Works as intented, thanks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #6956
When no custom hostname is configured, the server binds to all interfaces (
0.0.0.0), but the startup log either showed just the port number orlocalhost, which could be misleading — implying the server is only accessible on loopback.This updates both
server.jsandsetup-database.jsto display0.0.0.0as the bind address when no hostname is explicitly set, accurately reflecting that the server is listening on all interfaces.