Skip to content

fix: Remove forced DOWN status in group monitor#7045

Merged
louislam merged 1 commit intolouislam:masterfrom
MayMeow:fix/upsidedown-group-monitor-fix1
Mar 1, 2026
Merged

fix: Remove forced DOWN status in group monitor#7045
louislam merged 1 commit intolouislam:masterfrom
MayMeow:fix/upsidedown-group-monitor-fix1

Conversation

@MayMeow
Copy link
Copy Markdown
Contributor

@MayMeow MayMeow commented Feb 24, 2026

Summary

My earlier changes to the group monitor explicitly override the status to 'DOWN' when the children are down which was not a problem with basic kind ofgroup monitor but causing problem when monitor is upside-down type.

I removed the line in my earlier code that casues the issue.

Please follow this checklist to avoid unnecessary back and forth (click to expand)
  • ⚠️ If there are Breaking change (a fix or feature that alters existing functionality in a way that could cause issues) I have called them out
  • 🧠 I have disclosed any use of LLMs/AI in this contribution and reviewed all generated content.
    I understand that I am responsible for and able to explain every line of code I submit.
  • 🔍 Any UI changes adhere to visual style of this project.
  • 🛠️ I have self-reviewed and self-tested my code to ensure it works as expected.
  • 📝 I have commented my code, especially in hard-to-understand areas (e.g., using JSDoc for methods).
  • 🤖 I added or updated automated tests where appropriate.
  • 📄 Documentation updates are included (if applicable).
  • 🧰 Dependency updates are listed and explained.
  • ⚠️ CI passes and is green.

Screenshots for Visual Changes

The monitor behavior afeter changes:

Image

I was not sure about behavior - especially if It should go trough "pending" state before the change when there is bigger retires number so I compare them with my instance Version: 1.23.16 that running in my lab and it looks OK to me. Screenshot bellow is here just for compare.

image

Copilot AI review requested due to automatic review settings February 24, 2026 23:20
@MayMeow MayMeow marked this pull request as draft February 24, 2026 23:21
@MayMeow MayMeow changed the title [WIP] fix: Remove forced DOWN status in group monitor fix: Remove forced DOWN status in group monitor Feb 24, 2026
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request fixes a critical bug with upside-down group monitors introduced in PR #6286. The issue was that group monitors in upside-down mode were incorrectly showing DOWN status even when they should show UP.

Changes:

  • Removes forced DOWN status assignment in GroupMonitorType.check() that prevented upside-down mode from working correctly
  • Allows the monitor's retry logic and status flipping mechanism to handle the status properly

@louislam louislam linked an issue Feb 25, 2026 that may be closed by this pull request
1 task
@MayMeow MayMeow marked this pull request as ready for review February 25, 2026 08:49
@github-actions github-actions bot added the pr:needs review this PR needs a review by maintainers or other community members label Feb 25, 2026
@louislam
Copy link
Copy Markdown
Owner

louislam commented Mar 1, 2026

Thanks, I think it works.

@louislam louislam merged commit 111e981 into louislam:master Mar 1, 2026
32 of 34 checks passed
@CommanderStorm CommanderStorm added this to the 2.2.0 milestone Mar 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr:needs review this PR needs a review by maintainers or other community members

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Upside Down Mode Not Working for Group Monitors Anymore

4 participants