fix: Remove forced DOWN status in group monitor#7045
Merged
louislam merged 1 commit intolouislam:masterfrom Mar 1, 2026
Merged
fix: Remove forced DOWN status in group monitor#7045louislam merged 1 commit intolouislam:masterfrom
louislam merged 1 commit intolouislam:masterfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request fixes a critical bug with upside-down group monitors introduced in PR #6286. The issue was that group monitors in upside-down mode were incorrectly showing DOWN status even when they should show UP.
Changes:
- Removes forced DOWN status assignment in GroupMonitorType.check() that prevented upside-down mode from working correctly
- Allows the monitor's retry logic and status flipping mechanism to handle the status properly
1 task
Owner
|
Thanks, I think it works. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
My earlier changes to the group monitor explicitly override the status to 'DOWN' when the children are down which was not a problem with basic kind ofgroup monitor but causing problem when monitor is upside-down type.
I removed the line in my earlier code that casues the issue.
Please follow this checklist to avoid unnecessary back and forth (click to expand)
I understand that I am responsible for and able to explain every line of code I submit.
Screenshots for Visual Changes
The monitor behavior afeter changes:
I was not sure about behavior - especially if It should go trough "pending" state before the change when there is bigger retires number so I compare them with my instance
Version: 1.23.16that running in my lab and it looks OK to me. Screenshot bellow is here just for compare.