fix: Fix domain validation not allowing for PTR DNS records#7048
fix: Fix domain validation not allowing for PTR DNS records#7048CommanderStorm merged 3 commits intolouislam:masterfrom
Conversation
|
Hello and thanks for lending a paw to Uptime Kuma! 🐻👋 |
|
Hi! I'm I would like to apply some automated changes to this pull request, but it looks like I don't have the necessary permissions to do so. To get this pull request into a mergeable state, please do one of the following two things:
|
|
Could you give an exaple and preferably add it as a testcase? |
|
@sgdc3 |
Pull request was converted to draft

Summary
This PR fixes an issue in the DNS monitoring entry form validation where IP addresses were incorrectly marked as invalid.
While domain names are required for most DNS record types, PTR records require IP addresses as lookup keys. The validation has been updated to allow IP addresses when the record type is PTR, while keeping domain validation for other record types.
Please follow this checklist to avoid unnecessary back and forth (click to expand)
I understand that I am responsible for and able to explain every line of code I submit.