fix(globalping): retry creating the measurement on status 500#7056
fix(globalping): retry creating the measurement on status 500#7056CommanderStorm merged 2 commits intolouislam:masterfrom
Conversation
CommanderStorm
left a comment
There was a problem hiding this comment.
Usually, a non-backoff retry on 500 server error is a bug and will mess with your infra.
(I would not merge this, if this were not directly coming from you..)
I assume you have the nessesary cirquit breakers in place to prevent this being an issue on your end.
This is right, of course. @radulucut, please update to use exponential backoff with up to 5 retries. I'd suggest params 2, 5, 5, based on this calculator though I suppose there should also be a cap based on the configured check frequency (e.g. if configured interval is 1 minute, the delay shouldn't be more than that, or that attempt might just get dropped after fewer retries). But for large intervals, having at least 5 minutes between the first and last attempts seems reasonable. |
Summary
In this pull request, the following changes are made:
Added a retry on status
500when creating Globalping measurements.Please follow this checklist to avoid unnecessary back and forth (click to expand)
I understand that I am responsible for and able to explain every line of code I submit.
Screenshots for Visual Changes
n/a