Skip to content

fix(globalping): retry creating the measurement on status 500#7056

Merged
CommanderStorm merged 2 commits intolouislam:masterfrom
radulucut:globalping-retry
Feb 26, 2026
Merged

fix(globalping): retry creating the measurement on status 500#7056
CommanderStorm merged 2 commits intolouislam:masterfrom
radulucut:globalping-retry

Conversation

@radulucut
Copy link
Copy Markdown
Contributor

@radulucut radulucut commented Feb 26, 2026

Summary

In this pull request, the following changes are made:

Added a retry on status 500 when creating Globalping measurements.

Please follow this checklist to avoid unnecessary back and forth (click to expand)
  • ⚠️ If there are Breaking change (a fix or feature that alters existing functionality in a way that could cause issues) I have called them out
  • 🧠 I have disclosed any use of LLMs/AI in this contribution and reviewed all generated content.
    I understand that I am responsible for and able to explain every line of code I submit.
  • 🔍 Any UI changes adhere to visual style of this project.
  • 🛠️ I have self-reviewed and self-tested my code to ensure it works as expected.
  • 📝 I have commented my code, especially in hard-to-understand areas (e.g., using JSDoc for methods).
  • 🤖 I added or updated automated tests where appropriate.
  • 📄 Documentation updates are included (if applicable).
  • 🧰 Dependency updates are listed and explained.
  • ⚠️ CI passes and is green.

Screenshots for Visual Changes

n/a

@CommanderStorm CommanderStorm changed the title fix: Globalping - retry creating the measurement on status 500 fix(globalping): retry creating the measurement on status 500 Feb 26, 2026
Copy link
Copy Markdown
Collaborator

@CommanderStorm CommanderStorm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Usually, a non-backoff retry on 500 server error is a bug and will mess with your infra.
(I would not merge this, if this were not directly coming from you..)

I assume you have the nessesary cirquit breakers in place to prevent this being an issue on your end.

@CommanderStorm CommanderStorm enabled auto-merge (squash) February 26, 2026 18:01
@CommanderStorm CommanderStorm merged commit bdcbd4c into louislam:master Feb 26, 2026
24 checks passed
@radulucut radulucut deleted the globalping-retry branch February 26, 2026 18:10
@CommanderStorm CommanderStorm added this to the 2.2.0 milestone Feb 26, 2026
@MartinKolarik
Copy link
Copy Markdown

Usually, a non-backoff retry on 500 server error is a bug and will mess with your infra.

This is right, of course. @radulucut, please update to use exponential backoff with up to 5 retries. I'd suggest params 2, 5, 5, based on this calculator though I suppose there should also be a cap based on the configured check frequency (e.g. if configured interval is 1 minute, the delay shouldn't be more than that, or that attempt might just get dropped after fewer retries). But for large intervals, having at least 5 minutes between the first and last attempts seems reasonable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Globalping: logged Failed to create measurement: api_error Internal Server Error.. feat: Globalping support

3 participants