Skip to content

fix(monitor-list): tag list do not update#7069

Merged
louislam merged 1 commit intomasterfrom
fix-7057
Feb 28, 2026
Merged

fix(monitor-list): tag list do not update#7069
louislam merged 1 commit intomasterfrom
fix-7057

Conversation

@louislam
Copy link
Copy Markdown
Owner

Summary

Force to retrieve the tag list when open the menu.

Hadn't touch this part previously, just realized that it was actually not implemented in reactive way.

Resolves #7057

Please follow this checklist to avoid unnecessary back and forth (click to expand)
  • ⚠️ If there are Breaking change (a fix or feature that alters existing functionality in a way that could cause issues) I have called them out
  • 🧠 I have disclosed any use of LLMs/AI in this contribution and reviewed all generated content.
    I understand that I am responsible for and able to explain every line of code I submit.
  • 🔍 Any UI changes adhere to visual style of this project.
  • 🛠️ I have self-reviewed and self-tested my code to ensure it works as expected.
  • 📝 I have commented my code, especially in hard-to-understand areas (e.g., using JSDoc for methods).
  • 🤖 I added or updated automated tests where appropriate.
  • 📄 Documentation updates are included (if applicable).
  • 🧰 Dependency updates are listed and explained.
  • ⚠️ CI passes and is green.

Copilot AI review requested due to automatic review settings February 28, 2026 22:46
@louislam louislam added this to the 2.2.0 milestone Feb 28, 2026
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR addresses a UI consistency issue in the monitor list’s Tags filter dropdown by refreshing the available tag list when the dropdown menu is opened, so newly created tags can appear without a full page reload.

Changes:

  • Add an openMenu emit to MonitorListFilterDropdown and trigger it on menu focus.
  • Listen for the dropdown “open” event in MonitorListFilter to re-fetch tags via Socket.IO.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
src/components/MonitorListFilterDropdown.vue Emits an “open menu” event when the dropdown receives focus and opens the menu.
src/components/MonitorListFilter.vue Hooks the tags dropdown open event to call getExistingTags() and refresh the tags list.
Comments suppressed due to low confidence (1)

src/components/MonitorListFilterDropdown.vue:36

  • @focusin bubbles for every focus change inside the dropdown (button -> menu items, etc.). With the new openMenu() handler this will emit openMenu repeatedly while the menu is already open, which can trigger repeated tag fetches / extra socket traffic and may cause re-render/focus glitches. Consider emitting only when transitioning from closed -> open (e.g., guard on this.open before emitting) or move the handler to a non-bubbling event/element so it fires once per open.
        openMenu() {
            this.$emit("openMenu");
            this.open = true;
        },

@louislam louislam merged commit fef4826 into master Feb 28, 2026
29 checks passed
@louislam louislam deleted the fix-7057 branch February 28, 2026 22:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update tags dropdown upon creation of a new tag

2 participants