fix: isParentActive return type to boolean#7121
fix: isParentActive return type to boolean#7121CommanderStorm merged 1 commit intolouislam:masterfrom
Conversation
Uses similar logic as isActive to force the original integer type to boolean to match the original intent.
|
Hello and thanks for lending a paw to Uptime Kuma! 🐻👋 |
There was a problem hiding this comment.
Pull request overview
Fixes Monitor.isParentActive to return a proper boolean (matching Monitor.isActive), avoiding 0 being returned for paused ancestors and improving downstream compatibility (e.g., consumers expecting strict booleans).
Changes:
- Update
Monitor.isParentActiveto useparent.active === 1so the method always returns a boolean.
|
@terisikk congrats on your first contribution to Uptime Kuma! 🐻 |
Uses similar logic as isActive to force the original integer type to boolean to match the original intent.
Summary
In this pull request, the following changes are made:
active: 0for paused monitors, notactive: true. The current behavior breaks the unofficial breml terraform provider.To disclose LLM usage, claude code was used to debug the issue, the fix is my own and matches what a similar part in the codebase does.
Please follow this checklist to avoid unnecessary back and forth (click to expand)
I understand that I am responsible for and able to explain every line of code I submit.