fix: improve domain expiry warning message for unsupported TLDs#7271
Closed
AKIB473 wants to merge 1 commit intolouislam:masterfrom
Closed
fix: improve domain expiry warning message for unsupported TLDs#7271AKIB473 wants to merge 1 commit intolouislam:masterfrom
AKIB473 wants to merge 1 commit intolouislam:masterfrom
Conversation
The previous log message only stated that the RDAP endpoint was not in the IANA database, which left users confused about what to do next. This expands the message to clarify the TLD is the issue and directs users to verify expiry manually via their registrar or https://lookup.icann.org. Relates to louislam#7190
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
In this pull request, the following changes are made:
The log warning for unsupported TLDs in domain expiry monitoring is improved to give users a clearer explanation and actionable guidance.
Relates to Clarify domain expiry warning for unsupported TLDs yet more #7190
Problem
The existing warning message:
Left users confused. Popular TLDs like
.deand.eunot supporting RDAP is counterintuitive, and the message gave no guidance on what to do next.Solution
The new message:
Changes:
Please follow this checklist to avoid unnecessary back and forth (click to expand)