git commit -m "Fix: allow mqtts:// in MQTT monitor hostname and updat…#7290
Open
Mrstragr wants to merge 1 commit intolouislam:masterfrom
Open
git commit -m "Fix: allow mqtts:// in MQTT monitor hostname and updat…#7290Mrstragr wants to merge 1 commit intolouislam:masterfrom
Mrstragr wants to merge 1 commit intolouislam:masterfrom
Conversation
…e validation hint" ### Fix MQTT monitor not accepting mqtts:// hostname This PR fixes an issue where `mqtts://` URLs were rejected in the MQTT monitor hostname field. ### Changes: * Updated UI hint to include `mqtts://` * Extended regex validation to allow `mqtts://` alongside existing protocols ### Notes: * Verified that backend does not restrict `mqtts://`, so this is a frontend-only fix Fixes louislam#7286
Collaborator
|
I am a bit sussed out by this change. There must be a reason why this was restricted to was before, but maybe this is an oversight. Can you share a screenshot of this working? |
Owner
|
https://www.iana.org/assignments/uri-schemes/uri-schemes.txt Maybe it is a valid change, because the protocol is listed in this list. But I never used MQTT, probably need someone who have used mqtts:// to review/approve this change, because it seems a bit tricky to understand it: https://stackoverflow.com/questions/59562215/how-can-i-get-the-mqtt-broker-url-starting-with-mqtts |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…e validation hint"
Fix MQTT monitor not accepting mqtts:// hostname
This PR fixes an issue where
mqtts://URLs were rejected in the MQTT monitor hostname field.Changes:
mqtts://mqtts://alongside existing protocolsNotes:
mqtts://, so this is a frontend-only fixFixes #7286
Summary
In this pull request, the following changes are made:
Please follow this checklist to avoid unnecessary back and forth (click to expand)
I understand that I am responsible for and able to explain every line of code I submit.
Screenshots for Visual Changes
UPDOWN