Repository navigation
Conversation
When a push monitor receives an UP heartbeat, retries are correctly reset to 0. However, when the monitor subsequently times out (no heartbeat received), the retry counter was not being reset for the UP鈫扗OWN transition. Instead, it continued from the previous retry count, causing the retry counter to increment incorrectly even after successful heartbeats. This fix checks if a push monitor is transitioning from UP to DOWN and resets the retry counter before applying retry logic. Fixes louislam#6586
Contributor
|
Hello and thanks for lending a paw to Uptime Kuma! 馃惢馃憢 |
Contributor
|
Hello! This pull request does not follow the repository's PR template and is being closed automatically. |
louislam
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Push monitors with retry logic were not resetting their retry counter after receiving an UP heartbeat. When the monitor subsequently timed out, the retry counter continued from the previous value instead of starting fresh from 0.
retries = 0in the catch block when transitioning from UP to error state on push monitorsTest plan
Fixes #6586