Repository navigation
Conversation
Owner
|
Thanks for taking the time to open a PR, I've taken an alternative approach to do this in JavaScript - see #4621 (comment) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
sharp always passes
tuneto heifsave, and the default isauto. The libheif aom plugin acceptsauto, but the x265 plugin only knowspsnr,ssim,grainandfastdecode, so it rejects it and every HEVC encode with default options fails withheif: Invalid parameter value (5.2006).This leaves
tuneunset when it isauto. libvips then skipsheif_encoder_set_parameter_string, so each encoder uses its own default. For aom that default is alreadyauto, so AV1 output doesn't change.I reproduced it on macOS with sharp built against a global libvips 8.18.7 and Homebrew libheif 1.23.6 (x265 4.3).
heif({ compression: 'hevc' })fails before this change and works after, via bothtoBufferandtoFile. AV1 output is byte-identical. I haven't added a unit test, since the prebuilt libvips has no HEVC encoder for CI to exercise. The existing unit tests all pass.Fixes #4621