Repository navigation
Conversation
`sigma` was declared without an initial value, so validation errors for
`blur({ sigma: 'x' })` and `blur('5')` always reported
"received undefined of type undefined". Initialise `sigma` from
`options` and pass `options.sigma` when validating the object form.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Owner
|
Thanks for the PR. I note the use of LLM-based tooling. Please can you, a human, confirm this meets the contribution guidelines. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
blur()reportsreceived undefined of type undefinedfor any invalidsigma,because the local
sigmavariable is passed toinvalidParameterErrorbefore it is assigned.blur({ sigma: 'x' })received undefined of type undefinedreceived x of type stringblur('5')received undefined of type undefinedreceived 5 of type stringThis initialises
sigmafromoptions, which also removes the redundant number branch,and passes
options.sigmawhen validating the object form.Unit tests are added for both cases. They fail without this change.
🤖 Generated with Claude Code