refactor(server): code quality and consistency audit#825
Merged
FelixTJDietrich merged 11 commits intoreact-flow-achievementsfrom Mar 11, 2026
Merged
refactor(server): code quality and consistency audit#825FelixTJDietrich merged 11 commits intoreact-flow-achievementsfrom
FelixTJDietrich merged 11 commits intoreact-flow-achievementsfrom
Conversation
Address 100+ findings from review: - Add @transactional to recalculation - Handle optimistic lock exceptions - Remove dead methods and queries - Fix registry duplicate bug - Fix division-by-zero guards - Fix diamond league color typo - Biome lint and accessibility fixes Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Contributor
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
github-actions
bot
added
application-server
…llApi The achievement package declares @NonNullApi, making all params/returns non-null by default. Remove 5 defensive null checks that are unreachable under this contract: - AchievementService: drop `condition = "#user != null"` from @Cacheable and the `if (user == null)` guard in getAllAchievementsWithProgress - AchievementRecalculationService: drop `condition = "#user != null"` from @CacheEvict and the workspace null check (workspace has @NotNull + nullable = false on JoinColumn) - DummyEvaluator: drop user null ternary (UserAchievement.user has @NotNull + nullable = false) Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
…audit Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
- Fix Java formatting in OpenAPIConfiguration.java (Prettier) - Fix Biome import ordering in AchievementNode.tsx and SkillTreeDesigner.tsx - Remove duplicate isHidden property in openapi.yaml (merge artifact) - Regenerate TypeScript API client types Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
… achievement services
…into code-quality-consistency-audit
…oller Reverts @validated, @notblank, and @PathVariable removal that changed the generated OpenAPI spec. Keeps non-spec improvements (LoggingUtils, formatting). Cannot regenerate openapi.yaml locally without Docker/DB. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
- Prettier auto-formatted AchievementController.java method signatures - Reverted openapi.yaml to base branch version (4bd2419) since all spec-affecting Java changes were already reverted in the previous commit Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
qpxxl-tum
reviewed
Mar 11, 2026
| userAchievement.getAchievementId(), | ||
| userAchievement.getUser().getLogin(), | ||
| event.eventType()); | ||
| user != null ? LoggingUtils.sanitizeForLog(user.getLogin()) : "unknown", |
Contributor
There was a problem hiding this comment.
getUser is annotated with @nonnull and therefore there is no nullcheck necessary here.
| } | ||
|
|
||
| @Transactional | ||
| private void recalculateUserInternal(User user) { |
Contributor
There was a problem hiding this comment.
@Transactional methods must be overridable. Will change it to protected.
| ) | ||
| @CacheEvict( | ||
| value = ACHIEVEMENT_PROGRESS_CACHE, | ||
| key = "#event.user().isPresent() ? #event.user().get().getId() : 0", |
Contributor
There was a problem hiding this comment.
Double null check is unnecessary since condition ensures user is present. Also mapping to id 0 is not good practise since that id could be another user in the database.
| switch (progressData.type) { | ||
| case "LinearAchievementProgress": { | ||
| // Logic for Counter Achievements (e.g., 5/10 PRs) | ||
| const current = progressData.current ?? 0; |
Contributor
There was a problem hiding this comment.
pogressData.current cannot be undefined as it is always a number.
…into code-quality-consistency-audit
FelixTJDietrich
merged commit c700048
into
react-flow-achievements
30 of 36 checks passed
Contributor
📚 Documentation Preview
|
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
@TransactionaltorecalculateUserInternal(), handle optimistic lock exceptionsAchievementService,AchievementRegistry,UserAchievementRepository@PositiveOrZero→@PositiveonLinearAchievementProgress.target@/alias imports, exported prop interfaces, proper type guardsHow to Test
cd server/application-server && ./mvnw compilecd webapp && npx tsc --noEmit