`Development`: Add compliance checker UI and popover by ge94zec · Pull Request #2317 · ls1intum/tum-apply

ge94zec · 2026-04-18T23:43:05Z

❗️DO NOT MERGE BEFORE #2064 ❗️

Checklist

General

I tested all changes and their related features with all corresponding user types.
Language: I followed the guidelines for inclusive, diversity-sensitive, and appreciative language.
I chose a title conforming to the naming conventions for pull requests.

Server

I documented the Java code using JavaDoc style.

Client

Important: I implemented the changes with a very good performance, prevented too many (unnecessary) REST calls and made sure the UI is responsive, even with large data (e.g. using paging).
I strictly followed the principle of data economy for all client-server REST calls.
I strictly followed the client coding and design guidelines.
I documented the TypeScript code using JSDoc style.
I added multiple screenshots/screencasts of my UI changes.

Motivation and Context

Closes: #2062

Description

Steps for Testing

Prerequisites:

Log in to TUMApply
Navigate to Create Position
Verify if analysis works for title and job description
Verify if popover are correct across language switches and if category count works correct

Review Progress

Code Review

Code Review 1

Manual Tests

Test 1

Screenshots

Test Coverage

Client

Class/File	Line Coverage	Lines	Expects	Ratio
job-creation-form.component.ts	61.84%	1138	124	10.9
base-input.component.ts	97.29%	101	?	?
editor.component.ts	76.19%	326	56	17.2
status-pill.component.ts	100.00%	18	?	?
ai-assistant-card.component.ts	90.74%	106	9	8.5
ai-compliance-popover.component.ts	100.00%	14	?	?

Server

Class/File	Line Coverage	Lines
AiService.java	8.62%	226
AiResource.java	50.00%	71

Last updated: 2026-04-19 17:32:11 UTC

added endpoint for compliance added ComplianceIssueDTO for later on highlighting added ComplianceIssueDTO[]

…side' into feat/2063-add-compliance-server-side

- refactored prompt - moved enum to constants - changed endpoint to POST temporary - removed unused imports

…nce-server-side # Conflicts: # openapi/openapi.yaml # src/main/java/de/tum/cit/aet/ai/service/AiService.java # src/main/java/de/tum/cit/aet/ai/web/AiResource.java # src/main/webapp/app/generated/.openapi-generator/FILES # src/main/webapp/app/generated/api/aiResourceApi.service.ts # src/main/webapp/app/generated/model/models.ts

@RequestBody

…ith dual-language support - Move score calculation from frontend to backend (AiService) to persist across navigation - Add genderBiasScore and complianceAnalysis fields to Job entity with Liquibase migration - Calculate combined inclusivity score as average of DE and EN gender bias analyses - Strip HTML tags via Jsoup before analysis to fix zero-score bug - Adjust autosave timer to prevent premature translation triggering to 5s debounce - Read persisted score from JobDTO/JobFormDTO instead of recomputing on frontend - Fix AiScoreRingComponent animation to only animate on first render or actual score change - Add TranslateComplianceDTO wrapper to avoid multiple @RequestBody parameters - Update analyzeCurrentJobDescription and translateAndPersistJobDescription to use plain text - added sanitization -> write + read in Job-Description - adjusted tests

…side' into feat/2063-add-compliance-server-side # Conflicts: # openapi/openapi.yaml # src/main/webapp/app/generated/api/ai-resource-api.ts

# Conflicts: # openapi/openapi.yaml # src/main/java/de/tum/cit/aet/ai/service/AiService.java # src/main/java/de/tum/cit/aet/job/dto/JobFormDTO.java # src/main/java/de/tum/cit/aet/job/service/JobService.java # src/main/resources/config/liquibase/master.xml # src/main/webapp/app/generated/model/job.ts

…side' into feat/2063-add-compliance-server-side

@ElementCollection

changed Json compliance field to @ElementCollection

…side' into feat/2063-add-compliance-server-side

-added server tests -prettier

github-actions · 2026-04-19T00:29:43Z

📊 Server Test Coverage Too Low

🔍 View coverage locally:

./gradlew test jacocoTestReport
open build/reports/jacoco/test/html/index.html

🌐 View coverage from GitHub:
Download the "coverage-report-server" artifact from this workflow run.

github-actions · 2026-04-19T00:30:33Z

🤖 No OpenAPI or client changes needed.

github-actions · 2026-04-19T00:44:12Z

🤖 No OpenAPI or client changes needed.

Cathy0123456789

Thank you, small comment while flying over the code

…-new-compliance-tab-in-sidebar # Conflicts: # src/main/resources/config/liquibase/changelog/00000000000033_add_ai_compliance_to_jobs.xml # src/main/resources/prompts/AnalyzeComplianceText.st # src/main/webapp/app/job/job-creation-form/job-creation-form.component.ts # src/main/webapp/app/shared/components/atoms/editor/editor.component.ts

github-actions · 2026-04-19T15:27:59Z

🤖 No OpenAPI or client changes needed.

github-actions · 2026-04-19T15:28:41Z

📊 Client Test Coverage Too Low

🔍 View coverage locally:

npm run test:ci
open build/test-results/vitest/coverage/index.html

🌐 View coverage from GitHub:
Download the "coverage-report-client" artifact from this workflow run.

github-actions · 2026-04-19T15:51:38Z

🤖 No OpenAPI or client changes needed.

github-actions · 2026-04-19T15:52:01Z

📊 Client Test Coverage Too Low

🔍 View coverage locally:

npm run test:ci
open build/test-results/vitest/coverage/index.html

🌐 View coverage from GitHub:
Download the "coverage-report-client" artifact from this workflow run.

…-new-compliance-tab-in-sidebar

github-actions · 2026-04-19T16:45:04Z

📊 Client Test Coverage Too Low

🔍 View coverage locally:

npm run test:ci
open build/test-results/vitest/coverage/index.html

🌐 View coverage from GitHub:
Download the "coverage-report-client" artifact from this workflow run.

github-actions · 2026-04-19T16:49:34Z

🤖 OpenAPI spec and client code auto-updated and committed.

codacy-production · 2026-04-19T16:50:21Z

Not up to standards ⛔

🔴 Issues 2 high · 2 minor

Alerts:
⚠ 4 issues (≤ 0 issues of at least minor severity)

Results:
4 new issues

Category Results

Security 2 high

CodeStyle 2 minor

View in Codacy

🟢 Metrics 16 complexity

Metric Results

Complexity 16

View in Codacy

_{TIP This summary will be updated as you push new changes. Give us feedback}

github-actions · 2026-04-19T16:53:10Z

🤖 No OpenAPI or client changes needed.

github-actions · 2026-04-19T16:53:47Z

📊 Client Test Coverage Too Low

🔍 View coverage locally:

npm run test:ci
open build/test-results/vitest/coverage/index.html

🌐 View coverage from GitHub:
Download the "coverage-report-client" artifact from this workflow run.

github-actions · 2026-04-19T17:28:47Z

🤖 No OpenAPI or client changes needed.

az108

Code + Tested 👍

ge94zec and others added 30 commits March 17, 2026 13:18

added prompt

7c1b236

added endpoint for compliance added ComplianceIssueDTO for later on highlighting added ComplianceIssueDTO[]

prettier

bf426b2

Merge branch 'main' into feat/2063-add-compliance-server-side

d25fb1e

chore: update OpenAPI spec and generated client

91c583e

updated java doc

5abed90

Merge remote-tracking branch 'origin/feat/2063-add-compliance-server-…

4a034ec

…side' into feat/2063-add-compliance-server-side

fix: change requests

ae98a60

- refactored prompt - moved enum to constants - changed endpoint to POST temporary - removed unused imports

Merge branch 'main' into feat/2063-add-compliance-server-side

6570dda

chore: update OpenAPI spec and generated client

33f4691

Merge branch 'main' into feat/2063-add-compliance-server-side

2502905

chore: update OpenAPI spec and generated client

e392f27

Merge remote-tracking branch 'origin/feat/2063-add-compliance-server-…

b66e7ca

…side' into feat/2063-add-compliance-server-side # Conflicts: # openapi/openapi.yaml # src/main/webapp/app/generated/api/ai-resource-api.ts

prettier

74b6b72

chore: update OpenAPI spec and generated client

de857d5

fix client tests

a641e92

fix client tests

7ec341d

Merge branch 'main' into feat/2063-add-compliance-server-side

17acc03

fix change requests

b8f8944

Merge remote-tracking branch 'origin/feat/2063-add-compliance-server-…

ce179aa

…side' into feat/2063-add-compliance-server-side

Merge branch 'main' into feat/2063-add-compliance-server-side

292f6de

changed ComplianceIssueDTO to class

f20fc15

changed Json compliance field to @ElementCollection

Merge remote-tracking branch 'origin/feat/2063-add-compliance-server-…

a9f0fe5

…side' into feat/2063-add-compliance-server-side

chore: update OpenAPI spec and generated client

140fd6a

eslint

4ccd2b6

Merge remote-tracking branch 'origin/feat/2063-add-compliance-server-…

db09e52

…side' into feat/2063-add-compliance-server-side

-refactored comments

3ca255c

-added server tests -prettier

client and server tests fix

97e4fd4

ge94zec linked an issue Apr 18, 2026 that may be closed by this pull request

Feature: Add new compliance tab in sidebar #2062

Closed

3 tasks

fix bug

0ceeed6

server test fix

4f736a9

ge94zec marked this pull request as ready for review April 19, 2026 00:42

ge94zec requested a review from az108 as a code owner April 19, 2026 00:42

Cathy0123456789 requested changes Apr 19, 2026

View reviewed changes

Comment thread src/main/webapp/i18n/de/job.json Outdated

fix merge conflict issues

541340c

az108 added 2 commits April 19, 2026 18:40

create custom component for compliance checker category pills

21582d3

Merge remote-tracking branch 'origin/main' into feat/2062-feature-add…

e540a58

…-new-compliance-tab-in-sidebar

az108 and others added 2 commits April 19, 2026 18:46

create custom component for compliance checker category pills

3fc6df4

chore: update OpenAPI spec and generated client

b91a41a

helios-aet bot deployed to test-server April 19, 2026 16:55 Active

prettier/lint

ef1da78

az108 approved these changes Apr 19, 2026

View reviewed changes

az108 merged commit 4c9a67a into main Apr 19, 2026
15 of 16 checks passed

az108 deleted the feat/2062-feature-add-new-compliance-tab-in-sidebar branch April 19, 2026 17:33

Conversation

ge94zec commented Apr 18, 2026 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Checklist

General

Server

Client

Motivation and Context

Description

Steps for Testing

Review Progress

Code Review

Manual Tests

Screenshots

Test Coverage

Client

Server

Uh oh!

github-actions bot commented Apr 19, 2026

Uh oh!

github-actions bot commented Apr 19, 2026

Uh oh!

github-actions bot commented Apr 19, 2026

Uh oh!

Cathy0123456789 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

github-actions bot commented Apr 19, 2026

Uh oh!

github-actions bot commented Apr 19, 2026

Uh oh!

github-actions bot commented Apr 19, 2026

Uh oh!

github-actions bot commented Apr 19, 2026

Uh oh!

github-actions bot commented Apr 19, 2026

Uh oh!

github-actions bot commented Apr 19, 2026

Uh oh!

codacy-production bot commented Apr 19, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Not up to standards ⛔

Uh oh!

github-actions bot commented Apr 19, 2026

Uh oh!

github-actions bot commented Apr 19, 2026

Uh oh!

github-actions bot commented Apr 19, 2026

Uh oh!

az108 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

ge94zec commented Apr 18, 2026 •

edited by github-actions bot

Loading

codacy-production bot commented Apr 19, 2026 •

edited

Loading