Add support for pattern synonyms #287
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RaoulHC
force-pushed
the
pattern-synonyms
branch
4 times, most recently
from
13b1e60 to
5a8b9a0
Compare
RaoulHC
force-pushed
the
pattern-synonyms
branch
from
5a8b9a0 to
dfa3fef
Compare
Owner
|
Thanks! Sorry I have not reviewed this yet. Will do |
Owner
|
Looks good. Found and fixed one broken cases (multiple equations for the bidirectional case). Can be merged once it passes CI. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Saw Brittany didn't support pattern synonyms so thought I'd have a go at adding it.
Not sure if there should be more alternative layouts for pattern synonyms, but I think this is a sensible start.
Closes #199