Sorted imports 2 #330
Merged
Sorted imports 2 #330
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tfausak
reviewed
Dec 10, 2020
| import TestJustAbitToLongModuleNameLikeThisOneIs () | ||
| import MoreThanSufficientlyLongModuleNameWithSome | ||
| (items, that, will, not, fit, inA, compact, layout) | ||
| (compact, fit, inA, items, layout, not, that, will) |
Collaborator
There was a problem hiding this comment.
😆 These are funny now that they're sorted.
Contributor
Author
There was a problem hiding this comment.
If you can think of an alphabetical sentence with the same meaning we should use that!
Collaborator
Not that I know of, but it seems like there should be! |
tfausak
approved these changes
Dec 11, 2020
Collaborator
tfausak
left a comment
tfausak
left a comment
There was a problem hiding this comment.
I can't really speak to the code, but the result (sorting imports) looks great! Thanks for sticking with this and getting it over the line.
Closed
Contributor
Author
|
Thanks!
…On Fri, Dec 11, 2020, 11:44 PM Taylor Fausak ***@***.***> wrote:
Merged #330 <#330> into master.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#330 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAGRJXGIFKP575X6AWALH3LSUI47JANCNFSM4UUOEFFQ>
.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've merged the ghc 8.10 branch against the sorted-import branch and added some basic tests (Had to add a blank line function to the test suite)
I'm not sure if I'm being dense, but are there any tests where one enters the initial and expected source files, or is every test a "passthrough" test. i.e. would the identity function pass the testsuite?!
(I've targeted this against the ghc-8.10 branch because it includes those commits too)
The only required checklist items on @lspitzner's PR were:
(reopened from #325)