DM-50987: Add sattle to pipelines #333
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ebellm
changed the title
ktlim
reviewed
Jul 15, 2025
kfindeisen
approved these changes
Jul 23, 2025
There was a problem hiding this comment.
Looks good, modulo my comment on lsst/ap_pipe#235 about a pipeline parameter being cleaner.
For the record, this PR can't be merged until we have a base build with the new config fields. I would prefer that we run some PP integration tests as well (which are also blocked on an updated base).
|
Base container is out, so I expect unit tests will work This PR must be merged with lsst-sqre/phalanx#5162, otherwise the LSSTCam pipelines will break. |
|
|
|
test failure should be fixed now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.