Skip to content

Conversation

y5nw
Copy link
Contributor

@y5nw y5nw commented May 25, 2025

Add compact, short information about your PR for easier understanding:

  • Goal of the PR
    Add text composition/edit events to Luanti.
  • Does it resolve any reported issue?
    No.
  • Does this relate to a goal in the roadmap?
    No.
  • If not a bug fix, why is this PR needed? What usecases does it solve?
    IMO this is a minor quality of life improvement as some dead/compose keys do not show the status of text composition otherwise.

To do

This PR is a Work in Progress.

  • Introduce text composition event to Irrlicht.
  • Correctly handle text coposition:
    • Restore selected text when composition is canceled.
    • Correctly handle overwrite mode.
    • Correctly place the cursor within text composition.
  • Make UI elements use text composition:
    • CGUIEditBox
    • Chat console
  • Code refactoring?

How to test

Enter text using an IME / compose key / dead key and observe that "partial" input is also shown in the input box.

@y5nw y5nw added Feature ✨ PRs that add or enhance a feature @ Client / Controls / Input UI/UX labels May 25, 2025
@Zughy Zughy added the Roadmap: supported by core dev PR not adhering to the roadmap, yet some core dev decided to take care of it label May 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
@ Client / Controls / Input Feature ✨ PRs that add or enhance a feature Roadmap: supported by core dev PR not adhering to the roadmap, yet some core dev decided to take care of it UI/UX
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants