Skip to content
This repository was archived by the owner on May 30, 2022. It is now read-only.
This repository was archived by the owner on May 30, 2022. It is now read-only.

Query params inside last uri param #50

@hombrew

Description

@hombrew

Hello!

Currently, this lib does not support query params.

What I mean is, suppose you have this route

DeepLinking.addScheme('domain://');
DeepLinking.addRoute('/queryparams/:id', ({id}) => console.log('id: ', id))

when evaluating the uri, id gets query params concatenated:

DeepLinking.evaluateUrl('domain://queryparams/1234?q=query&p=param');
// console.log => id: 1234?q=query&p=param

is there any way to get around this?

my intentions isn't to get the query params, but for them to not get concatenated to the last uri param.

probably in a next version, it would be nice for the addRoute callback to receive:

{ path, scheme, match, params, query }

I can send a PR with what I just wrote, but it would be a breaking change.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions