Breaking change in v1.10.0+

[ljharb]

psl v1 doesn't have an engines field, which means it supports all versions of node.

v1.9 and below worked fine in node <= 4, but v1.10.0 contains untranspiled spread syntax and const/lets, and thus breaks in node 4 and below. Can you restore that support in a v1? It's fine to publish a v2 that drops it explicitly after that, of course :-)

(i'd also suggest expanding the CI matrix to include every supported node version, not just down to v8)

[mfdebian]

Thank you for the issue and for your patience! 🙏

I was able to reproduce the error using node lts/argon (v4.9.1), but it's working fine from lts/boron (v6.17.1) upwards.

We'll discuss this and get back to you shortly! 🙌

[ljharb]

@mfdebian thanks! appreciate the consideration.

[ljharb]

@mfdebian any update? this is still an inconvenience in multiple packages.

[mfdebian]

Hello @ljharb!

First of all, sorry for taking so long, life got in the way and I was unable to fix this issue

I'm going to work on this during this week and will get back to you as soon as it's fixed

Thanks for the patience and really sorry for the inconvenience 🙏

[mfdebian]

@ljharb just to be clear, if I were to add support for Node version lts/argon would you consider this issue as solved? or do you actually need support for node < 4? I'm asking because I think I can add support for Node lts/argon but older than that can get trickier and messy for maintainability for me

[ljharb]

@mfdebian I still do need < 4. One thing you could do is publish the current v1 as v2 (with an explicit engines.node declaration), and then republish v1.9 as the latest v1 - then you can drop support for whatever you want and avoid a maintainability issue.

[mfdebian]

Perfect, I'll follow your advise! Thank you!

[ljharb]

thank you for being open to fixing it!