-
Notifications
You must be signed in to change notification settings - Fork 41
Use rustpkg #24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use rustpkg #24
Conversation
This isn't really useful anymore, since we don't have any way of manipulating these from OpenCL kernels. It also lets us work around current Rust bugs.
There is a handful of new warns added.
Not worried about the package_id one. But the unused imports should probably be cleaned up. Tests are passing for me. |
|
||
use OpenCL::hl::*; | ||
|
||
#[nolink] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are these extra link steps needed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was getting link errors without them. I suspect this is due to rust-lang/rust#10199.
+1. Only minor nitpicks. |
Thanks, @csherratt! I made took your suggestions. |
This pull request rearranges all the code to work with rustpkg. It's a pretty big change and may impact what others are working on, so I'd like to have someone else review and make the final merge decision.
I also removed
Unique
, since we decided it isn't super useful right now, and it was causing trouble withrustc
.Unfortunately, we had to move all the tests into a single
test.rs
file.