Skip to content

Use rustpkg #24

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Nov 13, 2013
Merged

Use rustpkg #24

merged 10 commits into from
Nov 13, 2013

Conversation

eholk
Copy link
Collaborator

@eholk eholk commented Nov 12, 2013

This pull request rearranges all the code to work with rustpkg. It's a pretty big change and may impact what others are working on, so I'd like to have someone else review and make the final merge decision.

I also removed Unique, since we decided it isn't super useful right now, and it was causing trouble with rustc.

Unfortunately, we had to move all the tests into a single test.rs file.

@ghost
Copy link

ghost commented Nov 13, 2013

There is a handful of new warns added.

/home/colin/Source/rust-opencl/src/OpenCL/mem.rs:6:4: 6:17 warning: unused import, #[warn(unused_imports)] on by default
/home/colin/Source/rust-opencl/src/OpenCL/mem.rs:6 use std::unstable;
                                                       ^~~~~~~~~~~~~
/home/colin/Source/rust-opencl/src/OpenCL/mem.rs:7:4: 7:27 warning: unused import, #[warn(unused_imports)] on by default
/home/colin/Source/rust-opencl/src/OpenCL/mem.rs:7 use std::unstable::raw::Vec;
                                                       ^~~~~~~~~~~~~~~~~~~~~~~
/home/colin/Source/rust-opencl/src/OpenCL/mem.rs:8:4: 8:13 warning: unused import, #[warn(unused_imports)] on by default
/home/colin/Source/rust-opencl/src/OpenCL/mem.rs:8 use std::cast;
                                                       ^~~~~~~~~
warning: missing crate link meta `package_id`, using `OpenCL` as default
note: Installed package OpenCL-0.1 to /home/colin/Source/rust-opencl
note: Installed package OpenCL-0.1 to /home/colin/Source/rust-opencl
/home/colin/Source/rust-opencl/src/OpenCL/test.rs:47:8: 47:17 warning: unused import, #[warn(unused_imports)] on by default
/home/colin/Source/rust-opencl/src/OpenCL/test.rs:47     use std::cast;
                                                             ^~~~~~~~~

Not worried about the package_id one. But the unused imports should probably be cleaned up.

Tests are passing for me.


use OpenCL::hl::*;

#[nolink]
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are these extra link steps needed?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was getting link errors without them. I suspect this is due to rust-lang/rust#10199.

@ghost
Copy link

ghost commented Nov 13, 2013

+1.

Only minor nitpicks.

@eholk
Copy link
Collaborator Author

eholk commented Nov 13, 2013

Thanks, @csherratt! I made took your suggestions.

eholk added a commit that referenced this pull request Nov 13, 2013
@eholk eholk merged commit 5c35e6d into luqmana:master Nov 13, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant